Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314968: Public InputMap (v3) #1495

Draft
wants to merge 27 commits into
base: master
Choose a base branch
from

Conversation

andy-goryachev-oracle
Copy link
Contributor

@andy-goryachev-oracle andy-goryachev-oracle commented Jul 5, 2024

Summary

Add the InputMap property in the Control class which enables customization of controls with the application key mappings and event handlers, and to guarantee specific order of event handlers invocation and priority of application mappings over those created by the skin.

Add SkinInputMap and optional BehaviorBase classes to simplify creation of skins for existing and new controls.

Goals

The goals of this proposal are:

  • allow for customization of a control behavior by changing the existing or adding new key mappings
  • support dynamic modification of key mappings
  • allow for accessing the default functionality even when it was overwritten by the application
  • allow for reverting customization to the default implementation
  • guarantee priorities between the application and the skin event handlers and key mappings
  • allow for gradual migration of the existing controls to use the new InputMap
  • support stateful and stateless (fully static) behavior implementations

Non-Goals

It is not the goal of this proposal:

  • to require specific base class for the behavior implementations
  • to allow for complete decoupling of the skin from the behavior
  • to make the legacy internal InputMap class public
  • to make existing core behaviors public

Complete proposal:
https://github.com/andy-goryachev-oracle/Test/blob/main/doc/InputMap/InputMapV3.md


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1495/head:pull/1495
$ git checkout pull/1495

Update a local copy of the PR:
$ git checkout pull/1495
$ git pull https://git.openjdk.org/jfx.git pull/1495/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1495

View PR using the GUI difftool:
$ git pr show -t 1495

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1495.diff

@andy-goryachev-oracle andy-goryachev-oracle marked this pull request as draft July 5, 2024 15:19
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 5, 2024

👋 Welcome back angorya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 5, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 30, 2024

@andy-goryachev-oracle This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@andy-goryachev-oracle
Copy link
Contributor Author

keep alive

@openjdk
Copy link

openjdk bot commented Oct 22, 2024

@andy-goryachev-oracle this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout 8314968.input.map.v3
git fetch https://git.openjdk.org/jfx.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Oct 22, 2024
@openjdk openjdk bot removed the merge-conflict Pull request has merge conflict with target branch label Oct 22, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 30, 2024

@andy-goryachev-oracle This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

2 similar comments
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 31, 2024

@andy-goryachev-oracle This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 31, 2024

@andy-goryachev-oracle This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@andy-goryachev-oracle
Copy link
Contributor Author

keep-alive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant