-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8314968: Public InputMap (v3) #1495
base: master
Are you sure you want to change the base?
8314968: Public InputMap (v3) #1495
Conversation
👋 Welcome back angorya! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@andy-goryachev-oracle This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
keep alive |
@andy-goryachev-oracle this pull request can not be integrated into git checkout 8314968.input.map.v3
git fetch https://git.openjdk.org/jfx.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
@andy-goryachev-oracle This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
2 similar comments
@andy-goryachev-oracle This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@andy-goryachev-oracle This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
keep-alive. |
Summary
Add the InputMap property in the Control class which enables customization of controls with the application key mappings and event handlers, and to guarantee specific order of event handlers invocation and priority of application mappings over those created by the skin.
Add SkinInputMap and optional BehaviorBase classes to simplify creation of skins for existing and new controls.
Goals
The goals of this proposal are:
Non-Goals
It is not the goal of this proposal:
Complete proposal:
https://github.com/andy-goryachev-oracle/Test/blob/main/doc/InputMap/InputMapV3.md
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1495/head:pull/1495
$ git checkout pull/1495
Update a local copy of the PR:
$ git checkout pull/1495
$ git pull https://git.openjdk.org/jfx.git pull/1495/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1495
View PR using the GUI difftool:
$ git pr show -t 1495
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1495.diff