Skip to content

Conversation

@wasabii
Copy link

@wasabii wasabii commented Dec 1, 2025

InputStream not being closed on exception. Causes a test to fail under some conditions.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u.git pull/81/head:pull/81
$ git checkout pull/81

Update a local copy of the PR:
$ git checkout pull/81
$ git pull https://git.openjdk.org/jdk8u.git pull/81/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 81

View PR using the GUI difftool:
$ git pr show -t 81

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u/pull/81.diff

…ausing the file to remain open and breaking the GetSoundBankSecurityException test which immediately tries to delete it.
@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Dec 1, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 1, 2025

Hi @wasabii, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user wasabii" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Dec 1, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@wasabii
Copy link
Author

wasabii commented Dec 1, 2025

/signed

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Dec 1, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 1, 2025

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@gnu-andrew
Copy link
Member

gnu-andrew commented Dec 5, 2025

  1. Changes for OpenJDK 8 should go to https://github.com/openjdk/jdk8u-dev unless they are a regression fix for an upcoming release during the "rampdown" period; see https://wiki.openjdk.org/display/jdk8u/Main for details and the release schedule.
  2. We rarely accept new changes into OpenJDK 8 as it is a stable released version. New changes should instead go to https://github.com/openjdk/jdk and then be backported through the various stable releases. This ensures fixes are not regressed in later releases. In the case of this change, a fix was already introduced in OpenJDK 9 - https://bugs.openjdk.org/browse/JDK-8013586 - so the appropriate thing to do would be to backport this change to 8u-dev. It is more involved than your fix, as it fixes the same issue in multiple providers and also refactors some methods so they are provided by a common superclass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status

Development

Successfully merging this pull request may close these issues.

2 participants