8339882: Replace ThreadLocalStorage::thread with Thread::current_or_null in jdk8 backport of JDK-8183925

[benty-amzn]

This change replaces 3 instances of ThreadLocalStorage::thread with Thread::current_or_null to ensure that ThreadLocalStorage::is_initialized is checked before attempting to get the current thread.

Change passes all tier1 tests locally on Linux x86_64 and Windows x86_64

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• JDK-8339882 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8339882: Replace ThreadLocalStorage::thread with Thread::current_or_null in jdk8 backport of JDK-8183925 (Bug - P4 - Requested)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/576/head:pull/576
$ git checkout pull/576

Update a local copy of the PR:
$ git checkout pull/576
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/576/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 576

View PR using the GUI difftool:
$ git pr show -t 576

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/576.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back btaylor! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[mlbridge]

Webrevs

• 00: Full (cb59935d)

[openjdk]

⚠️ @benty-amzn This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[benty-amzn]

Checked the jtreg failures in github actions and I believe they're all unrelated to this change. I also see identical failures on at least one other open PR.

[benty-amzn]

/approval request Change 3 instances of ThreadLocalStorage::thread with Thread::current_or_null to retroactively make JDK-8183925 cleaner and ensure that ThreadLocalStorage::is_initialized is checked before attempting to get the current thread.

[openjdk]

@benty-amzn
8339882: The approval request has been created successfully.

[bridgekeeper]

@benty-amzn This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@benty-amzn This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@benty-amzn This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@benty-amzn This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!