Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297088: Update LCMS to 2.14 #569

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Aug 28, 2024

...placeholder...


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8273135 needs maintainer approval
  • JDK-8297088 needs maintainer approval

Issues

  • JDK-8297088: Update LCMS to 2.14 (Bug - P3)
  • JDK-8273135: java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java crashes in liblcms.dylib with NULLSeek+0x7 (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/569/head:pull/569
$ git checkout pull/569

Update a local copy of the PR:
$ git checkout pull/569
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/569/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 569

View PR using the GUI difftool:
$ git pr show -t 569

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/569.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 28, 2024

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@mrserb mrserb changed the base branch from master to pr/563 August 28, 2024 04:05
@openjdk
Copy link

openjdk bot commented Aug 28, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 2c692aa3567fff446b1a3263023077d8b4236945 8297088: Update LCMS to 2.14 Aug 28, 2024
@openjdk
Copy link

openjdk bot commented Aug 28, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Aug 28, 2024
@mrserb
Copy link
Member Author

mrserb commented Aug 28, 2024

/issue add 8273135

@openjdk
Copy link

openjdk bot commented Aug 28, 2024

@mrserb
Adding additional issue to issue list: 8273135: java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java crashes in liblcms.dylib with NULLSeek+0x7.

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/563 to master September 9, 2024 21:05
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout lcms2.14
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 31, 2024

@mrserb This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

2 similar comments
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 31, 2024

@mrserb This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 31, 2024

@mrserb This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant