Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8313374: --enable-ccache's CCACHE_BASEDIR breaks builds #2960

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Nov 5, 2024

Hi all,

This pull request contains a backport of commit 571c435e from the openjdk/jdk repository.

The commit being backported was authored by Jan Kratochvil on 23 Aug 2023 and was reviewed by Erik Joelsson.

Without this PR, the jdk build with --enable-ccache can't generate comments in -XX:+PrintInterpreter, this PR fix the build issue. So I want to backport this PR to jdk11u-dev from jdk22.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8313374 needs maintainer approval

Issue

  • JDK-8313374: --enable-ccache's CCACHE_BASEDIR breaks builds (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2960/head:pull/2960
$ git checkout pull/2960

Update a local copy of the PR:
$ git checkout pull/2960
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2960/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2960

View PR using the GUI difftool:
$ git pr show -t 2960

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2960.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 5, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 5, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 18ea311a328ffba286c72fe9035cb395c187aae9 8313374: --enable-ccache's CCACHE_BASEDIR breaks builds Nov 5, 2024
@openjdk
Copy link

openjdk bot commented Nov 5, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 5, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 5, 2024
@sendaoYan
Copy link
Member Author

/approval request Clean backport to fix build bug with --enable-ccache. Without this PR, the jdk build with --enable-ccache can't generate comments with JVM option -XX:+PrintInterpreter, this PR will fix the build issue. So I want to backport this PR to jdk11u-dev from jdk22.

@openjdk
Copy link

openjdk bot commented Nov 5, 2024

@sendaoYan
8313374: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Nov 5, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 5, 2024

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant