-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8328242: Add a log area to the PassFailJFrame #2959
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back toshiogata! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request I would like to backport this patch for test maintainability. The patch applies cleanly. The risk is low as this only touches tests. Testing: some manual tests using PassFailJFrame. |
@toshiogata |
@toshiogata This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Hi all,
I would like to backport this patch to improve test maintainability for manual tests. The patch is clean.
Testing: manually checked some tests using PassFailJFrame, and confirmed that they work in the same way.
Thank you.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2959/head:pull/2959
$ git checkout pull/2959
Update a local copy of the PR:
$ git checkout pull/2959
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2959/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2959
View PR using the GUI difftool:
$ git pr show -t 2959
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2959.diff
Webrev
Link to Webrev Comment