Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8328242: Add a log area to the PassFailJFrame #2959

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

toshiogata
Copy link
Contributor

@toshiogata toshiogata commented Oct 22, 2024

Hi all,

I would like to backport this patch to improve test maintainability for manual tests. The patch is clean.
Testing: manually checked some tests using PassFailJFrame, and confirmed that they work in the same way.

Thank you.


Progress

  • JDK-8328242 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8328242: Add a log area to the PassFailJFrame (Enhancement - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2959/head:pull/2959
$ git checkout pull/2959

Update a local copy of the PR:
$ git checkout pull/2959
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2959/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2959

View PR using the GUI difftool:
$ git pr show -t 2959

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2959.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 22, 2024

👋 Welcome back toshiogata! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 22, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 9bc1b065db238b7c9d0562f9bd55d2f338c6ff3d 8328242: Add a log area to the PassFailJFrame Oct 22, 2024
@openjdk
Copy link

openjdk bot commented Oct 22, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 22, 2024

⚠️ @toshiogata This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 22, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 22, 2024

Webrevs

@toshiogata
Copy link
Contributor Author

/approval request I would like to backport this patch for test maintainability. The patch applies cleanly. The risk is low as this only touches tests. Testing: some manual tests using PassFailJFrame.

@openjdk
Copy link

openjdk bot commented Oct 22, 2024

@toshiogata
8328242: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Oct 22, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 19, 2024

@toshiogata This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant