8195675: Call to insertText with single character from custom Input Method ignored

[srl295]

@srl295 Could not automatically backport b8f2ec90 to openjdk/jdk11u-dev due to conflicts in the following files:

src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.m
Please fetch the appropriate branch/commit and manually resolve these conflicts by using the following commands in your personal fork of openjdk/jdk11u-dev. Note: these commands are just some suggestions and you can use other equivalent commands you know.

Fetch the up-to-date version of the target branch

$ git fetch --no-tags https://git.openjdk.org/jdk11u-dev.git master:master

Check out the target branch and create your own branch to backport

$ git checkout master
$ git checkout -b backport-srl295-b8f2ec90-master

Fetch the commit you want to backport

$ git fetch --no-tags https://git.openjdk.org/jdk.git b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd

Backport the commit

$ git cherry-pick --no-commit b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd

Resolve conflicts now

Commit the files you have modified

$ git add files/with/resolved/conflicts
$ git commit -m 'Backport b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd'
Once you have resolved the conflicts as explained above continue with creating a pull request towards the openjdk/jdk11u-dev with the title Backport b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd.

Below you can find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit b8f2ec90 from the openjdk/jdk repository.

The commit being backported was authored by Steven Loomis on 28 May 2024 and was reviewed by Phil Race.

PR: openjdk/jdk#17921

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8195675 needs maintainer approval

Issue

• JDK-8195675: Call to insertText with single character from custom Input Method ignored (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2954/head:pull/2954
$ git checkout pull/2954

Update a local copy of the PR:
$ git checkout pull/2954
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2954/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2954

View PR using the GUI difftool:
$ git pr show -t 2954

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2954.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back srl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @srl295 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[srl295]

/approval

[openjdk]

@srl295 usage: /approval [<id>] (request|cancel) [<text>]

[mlbridge]

Webrevs

• 02: Full - Incremental (98f35e83)
• 01: Full - Incremental (99d846f1)
• 00: Full (b1f954b1)

[srl295]

/approval request java.awt components did not work properly on macOS with custom input methods, the net effect is that minority language keyboards did not work properly with Java. Low risk, the fix handles this situation similarly to how Apple's own 'kotoeri' input method was handled on a long term basis, so it is a well-worn path. Patch should apply cleanly and was code reviewed

[openjdk]

@srl295
8195675: The approval request has been created successfully.

[srl295]

Built and verified this PR.

[srl295]

The macOS-12 environment is deprecated, consider switching to macOS-13, macOS-14 (macos-latest) or macOS-15. For more details, see actions/runner-images#10721