Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8338058: map_or_reserve_memory_aligned Windows enhance remap assertion #2939

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Sep 23, 2024


Progress

  • Change must not contain extraneous whitespace
  • JDK-8338101 needs maintainer approval
  • Commit message must refer to an issue
  • JDK-8338058 needs maintainer approval

Warning

 ⚠️ Found leading lowercase letter in issue title for 8338101: remove old remap assertion in map_or_reserve_memory_aligned after JDK-8338058

Issues

  • JDK-8338058: map_or_reserve_memory_aligned Windows enhance remap assertion (Enhancement - P4 - Requested)
  • JDK-8338101: remove old remap assertion in map_or_reserve_memory_aligned after JDK-8338058 (Enhancement - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2939/head:pull/2939
$ git checkout pull/2939

Update a local copy of the PR:
$ git checkout pull/2939
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2939/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2939

View PR using the GUI difftool:
$ git pr show -t 2939

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2939.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 23, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 23, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 5b9489546b50ec18dcfaf21caa8fb37c48eb7c3f 8338058: map_or_reserve_memory_aligned Windows enhance remap assertion Sep 23, 2024
@openjdk
Copy link

openjdk bot commented Sep 23, 2024

This backport pull request has now been updated with issues from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 23, 2024

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 23, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 23, 2024

Webrevs

@openjdk openjdk bot added the approval label Sep 23, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 21, 2024

@MBaesken This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant