Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8232367: Update Reactive Streams to 1.0.3 -- tests only #2921

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amosshi
Copy link
Contributor

@amosshi amosshi commented Aug 24, 2024

Backport of JDK-8232367

Testing

  • Local: Compile passed on MacOS 14.6.1 on Apple M1 Max
    • Not a test or directory containing tests: java/net/httpclient/reactivestreams-tck/org/reactivestreams/tck/SubscriberWhiteboxVerification.java
  • Pipeline: All passed except macOS
    • macOS: /Applications/Xcode_14.3.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/stdio.h:188:1: note: 'sprintf' has been explicitly marked deprecated here The issue exists in all recent PR in jdk11u-dev and not caused by Current PR
  • Testing Machine: We consider SAP nightlies passed on 2024-09-03
    • Because no test failure is found caused by SubscriberWhiteboxVerification.java

Progress

  • Change must not contain extraneous whitespace
  • JDK-8232367 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8232367: Update Reactive Streams to 1.0.3 -- tests only (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2921/head:pull/2921
$ git checkout pull/2921

Update a local copy of the PR:
$ git checkout pull/2921
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2921/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2921

View PR using the GUI difftool:
$ git pr show -t 2921

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2921.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 24, 2024

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 24, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 9f6af13f9d9d9b1f7a2b6eaac96240a51cadfd72 8232367: Update Reactive Streams to 1.0.3 -- tests only Aug 24, 2024
@openjdk
Copy link

openjdk bot commented Aug 24, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 24, 2024

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 24, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 24, 2024

Webrevs

@amosshi
Copy link
Contributor Author

amosshi commented Sep 5, 2024

/approval request "Backporting for parity with 11.0.25-oracle. No risk, test fix. Clean backport. Test passes and SAP nightlies pass on 2024-09-03”

@openjdk
Copy link

openjdk bot commented Sep 5, 2024

@amosshi
8232367: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Sep 5, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 3, 2024

@amosshi This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

3 similar comments
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 30, 2024

@amosshi This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 31, 2024

@amosshi This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 31, 2024

@amosshi This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant