8225045: javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails on linux-x64

[amosshi]

Backport of JDK-8225045

• This PR contains two commits
• commit 1 is generated by git patch command, is a clean backport for JInternalFrameIconTest.java
• commit 2 is the manual merge of test/jdk/ProblemList.txt.rej file. The content of the file is bellow.

@@ -751,7 +751,6 @@
 javax/swing/JComboBox/8182031/ComboPopupTest.java 8196465 linux-all,macosx-all
 javax/swing/JFileChooser/6738668/bug6738668.java 8194946 generic-all
 javax/swing/JInternalFrame/Test6325652.java 8224977 macosx-all
-javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java 8225045 linux-all
 javax/swing/JPopupMenu/4870644/bug4870644.java 8194130 macosx-all,linux-all
 javax/swing/PopupFactory/6276087/NonOpaquePopupMenuTest.java 8065099,8208565 macosx-all,linux-all
 javax/swing/UIDefaults/6302464/bug6302464.java 8199079 macosx-all

Testing

• Local on MacOS: Test passed on MacOS 14.6.1 on Apple M1 Max
  • JInternalFrameIconTest.java: Test results: passed: 1
• Local on Linux: Test passed on Ubuntu 22.04.4 by @Harry-Junhua-Huang
  • Passed: javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java
• Pipeline: All passed except macOS
  • macOS: /Applications/Xcode_14.3.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/stdio.h:188:1: note: 'sprintf' has been explicitly marked deprecated here The issue exists in all recent PR in jdk11u-dev and not caused by Current PR
• Testing Machine: SAP nightlies SKIPPED on 2024-08-23
  • Automated jtreg test: jtreg_jdk_tier4, Started at 2024-08-22 21:03:43+01:00
  • javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java: SKIPPED [Filter: Keywords - Not matching the given keyword expression: (((!headful)&(!printer)&(!intermittent))) & !manual & !ignore] GitHub 📊 - [0 msec]

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8225045 needs maintainer approval

Issue

• JDK-8225045: javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails on linux-x64 (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2918/head:pull/2918
$ git checkout pull/2918

Update a local copy of the PR:
$ git checkout pull/2918
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2918/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2918

View PR using the GUI difftool:
$ git pr show -t 2918

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2918.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@amosshi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8225045: javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails on linux-x64

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

• dd35f18: 8340671: GHA: Bump macOS and Xcode versions to macos-12 and XCode 13.4.1
• b2d3859: Merge
• 0358cbd: 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2
• 934decc: Merge
• 90ad5b1: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs
• 6ee8bac: 8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods
• ffcdc10: 8315936: Parallelize gc/stress/TestStressG1Humongous.java test
• 76b8327: 8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main
• 8c31358: 8328300: Convert PrintDialogsTest.java from Applet to main program
• ce572df: 8339082: Bump update version for OpenJDK: jdk-11.0.26
• ... and 7 more: https://git.openjdk.org/jdk11u-dev/compare/cd9e6cb584bfeb232bcea7a642664cb6dd4424f3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (af4173e6)

[mrserb]

This bug was reported on linux so you need to test the backport on linux as well.

[Harry-Junhua-Huang]

Test on local linux machine

System info

• tail /etc/lsb-release

DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=22.04
DISTRIB_CODENAME=jammy
DISTRIB_DESCRIPTION="Ubuntu 22.04.4 LTS"

• lscpu

Architecture:            x86_64
  CPU op-mode(s):        32-bit, 64-bit
  Address sizes:         48 bits physical, 48 bits virtual
  Byte Order:            Little Endian
CPU(s):                  16
  On-line CPU(s) list:   0-15
Vendor ID:               AuthenticAMD
  Model name:            AMD Ryzen 7 5800H with Radeon Graphics
    CPU family:          25
    Model:               80
    Thread(s) per core:  2
    Core(s) per socket:  8
    Socket(s):           1
    Stepping:            0
    BogoMIPS:            6387.77

Test result: passed

• Passed: javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java

[amosshi]

/approval request "Backporting for parity with 11.0.25-oracle. No risk, test fix. Clean backport. Test passes in local on both Ubuntu Linux and MacOS”

[openjdk]

@amosshi
8225045: The approval request has been created successfully.

[bridgekeeper]

@amosshi This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@amosshi This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@amosshi This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@amosshi This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!