fix: disambiguation about OPTIONAL vs REQUIRED for response_uri using direct_post method #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… direct_post method
peppelinux
requested review from
danielfett,
awoie,
Sakurann and
paulbastian
tlodderstedt
approved these changes
Jan 18, 2024
Sakurann
approved these changes
Feb 15, 2024
awoie
pushed a commit
that referenced
this pull request
Feb 19, 2024
… direct_post method (#72) editorial. 2 approvals. open for more than a week. Co-authored-by: Kristina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR remove the ambiguity we have in the direct_post section where the response_uri is set as OPTIONAL and at the same time is defined as REQUIRED when used in conjunction with direct_post
since the section is related to the direct_post, I suggest to convert that OPTIONAL to REQUIRED