Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alphabetically reorder acknowledgements list and make it more thorough. #67

Merged
merged 4 commits into from
Nov 29, 2023

Conversation

Sakurann
Copy link
Collaborator

@Sakurann Sakurann commented Nov 22, 2023

For the awareness purposes, adding for review those who I added in the list. will merge when few approvals come in.

cc some of those whom I could not add as reviewers @TakahikoKawasaki, @cobward

Copy link
Member

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll point out that the names were already in alphabetical order by last name, which is the typical sorting.

I'm not going to stand in the way of this on that basis because I think it's important to acknowledge everyone in the list, but I do find the change in sorting convention odd. Why was this changed?

@Sakurann
Copy link
Collaborator Author

VCI spec was not ordered at all and I automatically reordered both based on first name without realizing VP spec was already ordered. i am ok ordering based on the last name

@Sakurann Sakurann merged commit 517908f into main Nov 29, 2023
2 checks passed
@selfissued
Copy link
Member

Looks good now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants