Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request_uri extension #59

Merged
merged 100 commits into from
Mar 26, 2024
Merged
Changes from 2 commits
Commits
Show all changes
100 commits
Select commit Hold shift + click to select a range
0ef69f7
create sequence diagram
tlodderstedt Nov 2, 2023
b402aa7
added POST to indicate HTTP method
tlodderstedt Nov 2, 2023
673fcf7
added create_presentation_uri parameter
tlodderstedt Nov 2, 2023
9dff282
added create request endpoint
tlodderstedt Nov 2, 2023
f945d54
fixed iss
tlodderstedt Nov 2, 2023
0a42d0f
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Nov 8, 2023
37fbccf
added iat and exp
tlodderstedt Nov 8, 2023
b7c2570
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Nov 8, 2023
350391d
added trustworthiness check to sequence diagram
tlodderstedt Nov 8, 2023
7822756
Merge branch 'request_uri2' of https://github.com/openid/OpenID4VP in…
tlodderstedt Nov 8, 2023
8056fc1
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Nov 17, 2023
9061d50
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Nov 17, 2023
ba585be
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Nov 17, 2023
b1ee70e
reworked based on feedback from Paul and Giuseppe
tlodderstedt Dec 20, 2023
d29107b
some fixes
tlodderstedt Dec 20, 2023
d198019
fixed intendation
tlodderstedt Dec 20, 2023
30d59a8
changed parameter name according to Oliver's suggestion
tlodderstedt Dec 20, 2023
63a86f7
fixed request mode in diagram
tlodderstedt Jan 6, 2024
70ac39b
renamed w_nonce to issuer_nonce
tlodderstedt Jan 6, 2024
e35ab32
signed request is sent as request parameter
tlodderstedt Jan 6, 2024
8cb645f
note on nonce binding of vp_token content
tlodderstedt Jan 6, 2024
0ced90a
Update diagrams/request_uri_mode_create.md
tlodderstedt Jan 6, 2024
42f6866
Update diagrams/request_uri_mode_create.md
tlodderstedt Jan 6, 2024
4f335fc
added explanation why the first request should be signed
tlodderstedt Jan 6, 2024
18fd478
Merge branch 'request_uri2' of https://github.com/openid/OpenID4VP in…
tlodderstedt Jan 6, 2024
bfc2bdc
Apply editorial suggestions from Giuseppe
paulbastian Jan 14, 2024
acd0c13
added text on preceedence of request object claims over request claim…
tlodderstedt Jan 18, 2024
1101fda
adjusted diagram name to parameter name
tlodderstedt Jan 18, 2024
c1ee35a
added internal processing at the verifier's response endpoint
tlodderstedt Jan 18, 2024
357222c
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Jan 18, 2024
0844acb
fixed description of request_uri_method based on Giuseppe's feedback
tlodderstedt Jan 18, 2024
f0fa298
Merge branch 'request_uri2' of https://github.com/openid/OpenID4VP in…
tlodderstedt Jan 18, 2024
cfb2d36
changed text re signed authz request
tlodderstedt Jan 18, 2024
2c49b9b
fixed endpoint naming
tlodderstedt Jan 18, 2024
21696fd
Update diagrams/request_uri_mode_post.md
tlodderstedt Feb 8, 2024
a8f4917
Merge branch 'request_uri2' of https://github.com/openid/OpenID4VP in…
tlodderstedt Mar 9, 2024
2f08615
reworked the PR to reflect recent WG discussions
tlodderstedt Mar 9, 2024
9a021bb
Apply suggestions from code review
tlodderstedt Mar 11, 2024
8719239
Apply suggestions from code review
tlodderstedt Mar 11, 2024
e7b8871
reverted 3rd paragraph in Authz Request section
tlodderstedt Mar 11, 2024
9d78904
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Mar 11, 2024
0e58e39
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Mar 11, 2024
af6c572
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Mar 11, 2024
02a58d0
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Mar 11, 2024
76098d7
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Mar 11, 2024
8666529
simplified diagram
tlodderstedt Mar 11, 2024
396f007
added processing requirements
tlodderstedt Mar 11, 2024
b1e94aa
Merge branch 'request_uri2' of https://github.com/openid/OpenID4VP in…
tlodderstedt Mar 11, 2024
d9a49d9
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Mar 11, 2024
63d1f7f
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Mar 11, 2024
6edd8d1
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Mar 11, 2024
e8a6cde
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Mar 11, 2024
e1276ec
fixed media types
tlodderstedt Mar 11, 2024
6d5601b
Merge branch 'request_uri2' of https://github.com/openid/OpenID4VP in…
tlodderstedt Mar 11, 2024
c4d175b
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Mar 12, 2024
3b0a9fb
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Mar 12, 2024
df5d0f1
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Mar 12, 2024
f4e4236
removed "new"
tlodderstedt Mar 12, 2024
ac1ffc0
fixed wallet_metadata
tlodderstedt Mar 12, 2024
803cbe6
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Mar 12, 2024
95ac037
added request_uri POST example
tlodderstedt Mar 12, 2024
6890440
Merge branch 'request_uri2' of https://github.com/openid/OpenID4VP in…
tlodderstedt Mar 12, 2024
148e1bd
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Mar 12, 2024
ae65453
Apply suggestions from code review
tlodderstedt Mar 12, 2024
e3df8ac
moved requirement for request object up and fixed grammar nit
tlodderstedt Mar 12, 2024
0c9413d
Apply suggestions from code review
tlodderstedt Mar 12, 2024
91f811f
Apply suggestions from code review
tlodderstedt Mar 12, 2024
56ef646
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Mar 12, 2024
a21eba3
changed text on client_metadata and added case-sensitive to error text
tlodderstedt Mar 14, 2024
efd0722
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Mar 14, 2024
4ea299d
fixed history
tlodderstedt Mar 14, 2024
3208b16
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Mar 14, 2024
55a4faf
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Mar 14, 2024
5a0b1af
extended privacy considerations
tlodderstedt Mar 14, 2024
bee5ed9
Merge branch 'request_uri2' of https://github.com/openid/OpenID4VP in…
tlodderstedt Mar 14, 2024
286bf67
Update diagrams/request_uri_mode_post.md
tlodderstedt Mar 14, 2024
3c298b7
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Mar 14, 2024
4540cca
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Mar 14, 2024
e5add86
formatted Oliver's contribution
tlodderstedt Mar 14, 2024
06aef10
Apply suggestions from code review
tlodderstedt Mar 14, 2024
e437b50
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Mar 14, 2024
4140e35
Apply suggestions from code review
tlodderstedt Mar 14, 2024
1e033f7
made request_uri_method case-sensitive
tlodderstedt Mar 14, 2024
d167829
Merge branch 'request_uri2' of https://github.com/openid/OpenID4VP in…
tlodderstedt Mar 14, 2024
fb39140
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Mar 21, 2024
674d0aa
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Mar 21, 2024
fe8ae63
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Mar 21, 2024
1088682
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Mar 21, 2024
c6057d9
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Mar 21, 2024
e937d3a
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Mar 21, 2024
f36cfe6
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Mar 21, 2024
cdfea43
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Mar 21, 2024
1737a30
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Mar 21, 2024
d2ba099
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Mar 21, 2024
a478244
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Mar 21, 2024
c6db7d5
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Mar 21, 2024
d3e6894
Update openid-4-verifiable-presentations-1_0.md
tlodderstedt Mar 21, 2024
17a60fc
added privacy considerations
tlodderstedt Mar 21, 2024
ada0a45
Update diagrams/request_uri_mode_post.md
tlodderstedt Mar 25, 2024
6f9c661
changed additional message and note suggested by David to PlantUML fo…
tlodderstedt Mar 25, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion openid-4-verifiable-presentations-1_0.md
Original file line number Diff line number Diff line change
@@ -232,7 +232,7 @@ Presentation of Verifiable Credentials using OpenID for Verifiable Presentations

The Authorization Request follows the definition given in [@!RFC6749] taking into account the recommendations given in [@!I-D.ietf-oauth-security-topics].

The Verifier MAY send an Authorization Request as Request Object by value or by reference as defined in JWT-Secured Authorization Request (JAR) [@RFC9101]. Additionally, the request can be an object containing only a subset of parameters needed to, in a subsequent step, request the creation of a request object from the Verifier through an HTTPS POST request via a newly introduced `create request endpoint`.
The Verifier MAY send an Authorization Request as a Request Object either by value or by reference, as defined in the JWT-Secured Authorization Request (JAR) [@RFC9101]. The Request Object MAY contain a subset of parameters, which the Wallet uses to request the creation of a new Request Object from the Verifier. This request is made using an HTTP POST to the Verifier's `request_uri` endpoint. The Wallet MAY support this feature, which involves providing some details about its technical capabilities with the Verifier. This allows the Verifier to generate a Request Object that is specifically designed to match the capabilities of the Wallet making the request. Verifiers that support this feature MUST provide the `request_uri_method`, as defined below, to indicate to the Wallet that they support this feature.
tlodderstedt marked this conversation as resolved.
Show resolved Hide resolved
tlodderstedt marked this conversation as resolved.
Show resolved Hide resolved

The Verifier specifies the requirements for the Credential(s) being requested using the `presentation_definition` and `presentation_definition_uri` parameters. These parameters contain a Presentation Definition JSON object as outlined in Section 5 of [@!DIF.PresentationExchange]. Wallet implementations are required to process this Presentation Definition JSON object and select suitable Verifiable Credential(s) following the evaluation process detailed in Section 8 of [@!DIF.PresentationExchange].
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why we're changing this language about PE in this PR; I'd suggest dropping this change (particularly as it's causing a git conflict).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know when this was changed. Will revert it to the text in "main".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The Verifier specifies the requirements for the Credential(s) being requested using the `presentation_definition` and `presentation_definition_uri` parameters. These parameters contain a Presentation Definition JSON object as outlined in Section 5 of [@!DIF.PresentationExchange]. Wallet implementations are required to process this Presentation Definition JSON object and select suitable Verifiable Credential(s) following the evaluation process detailed in Section 8 of [@!DIF.PresentationExchange].
The Verifier specifies the requirements for the Credential(s) being requested using the `presentation_definition` or `presentation_definition_uri` parameters. These parameters contain a Presentation Definition JSON object as outlined in Section 5 of [@!DIF.PresentationExchange]. Wallet implementations are required to process this Presentation Definition JSON object and select suitable Verifiable Credential(s) following the evaluation process detailed in Section 8 of [@!DIF.PresentationExchange].

I presume the parameters are mutually exclusive?
Also, in case of the ...uri, the P.D. JSON is not contained in the parameter.