-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add intent to retain to claims query in DCQL #338
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not in favor of adding this and I think there have been good reasons/argumentations in the Issue. In short, the feature as-is is under-specified and likely of not much use and it seems more reasonable to convey this via the purpose
field.
WG discussion: agreement that this is not perfect (PR text should be improved), but probably good enough as a starting point to meet the requirements and have a transition path for those who us intent_to_retain in 18013-5/PE. |
A potential issue I see is that if this option is added in this form it will probably need to be maintained in the version it is introduced as it could be a breaking change to remove it. (maybe a parallel mechanism can be introduced that could be marked as preferred in 1.1? something like PEX vs DCQL) Other than that if the group is short on time and this option is required it may be a good compromise until a better mechanism is found. |
the feature is another option I considered when doing PR is to add intent_to_retain only to mdocs, but that did not feel in sprit of the specification, or the discussions we have been having.. |
Co-authored-by: Stefan Charsley <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good one!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am still not fully convinced that this feature on its own makes sense, but as it is an optional credential format specific feature that just matches the current capabilities in the ISO protocols, I guess it is fine to merge.
We can (and probably should imho) provide another solution in the direction of purpose in the long run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, this would cause interop issues. I know that certain members are in favor of providing some guidance to the user but it would cause confusion if this was done only for mdocs.
verbal approval to dismiss during the wg call
resolves #321