-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes mdoc/mdl section #128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there was an agreement in issue #62 to remove examples and only point to ISO specs.
also if you want to mention both 18013 and 23220, much more explanation is needed about the relationship between them. I am afraid the current text would confuse those not familiar.
Ok, let's discuss in the issue first. On the PR, I can give an intro sentence on what mdocs are similar to what we did for anoncreds. No need to mention more. For that reason the references for interested readers. |
@Sakurann I tried to incorporate your feedback in the PR. Could you please review again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks pretty good to me. one of the cleanest explanations of the relationship btw 18013, 23220 series and oid4vp that i have seen
Co-authored-by: Kristina <[email protected]>
Co-authored-by: Kristina <[email protected]>
Had to fix some of the references. SessionTranscript is defined in 18013-5/23220-4. OID4VPHandover is defined in 18013-7 and 23220-4. SessionTranscript is always the same for all protocols. OID4VP is just a specific protocol in ISO. Had to adjust the language. For that reason, please review again @Sakurann @jogu . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for requesting re-review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Are we sure we want to exclude all examples?
Yeah, I actually had the same question in the back of my mind... |
Aside from the very good reason Kristina mentioned, we also don't actually have any valid examples (there's an error in the ones currently in 18013-7) and they'd be a massive pain to generate. I think omitting them is the correct thing to do at the current time. Whether we might at some future point want to add them back in is a slightly separate discussion. |
This PR fixes the mso_mdoc sections by referring to the relevant documents that define the profile.
Fixes #62