Require state/nonce to only contain URL safe characters #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in #95 implementations often make mistakes handling characters that require escaping, character encoding conversion, etc. There is no advantage to using characters outside of the standard URL safe characters, and most people using base64url, UUIDs, JWTs, etc that are by default URL safe, so just make that restriction clear. closes #95
Sakurann
reviewed
Mar 6, 2024
Sakurann
approved these changes
Mar 6, 2024
Co-authored-by: Kristina <[email protected]>
tplooker
approved these changes
Mar 14, 2024
bc-pi
approved these changes
Mar 14, 2024
c2bo
approved these changes
Mar 16, 2024
|
Open for a few weeks, quite a few approvals and mentioned on a few working group calls without any objections been raised - merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #95 implementations often make mistakes handling characters that require escaping, character encoding conversion, etc. There is no advantage to using characters outside of the standard URL safe characters, and most people using base64url, UUIDs, JWTs, etc that are by default URL safe, so just make that restriction clear.
closes #95