Another warning hunting session #4484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ccess Signed-off-by: Gaël L'hopital <[email protected]>
holgerfriedrich
requested changes
Jan 1, 2025
...org.openhab.core/src/main/java/org/openhab/core/internal/library/unit/CurrencyConverter.java
Outdated
Show resolved
Hide resolved
...les/org.openhab.core/src/main/java/org/openhab/core/internal/scheduler/PeriodicAdjuster.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.core/src/main/java/org/openhab/core/types/StateOption.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.core/src/main/java/org/openhab/core/types/StateDescription.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.core/src/main/java/org/openhab/core/types/CommandOption.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.core/src/main/java/org/openhab/core/scheduler/CronAdjuster.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.core/src/main/java/org/openhab/core/internal/service/WatchServiceImpl.java
Outdated
Show resolved
Hide resolved
...openhab.core/src/main/java/org/openhab/core/internal/types/StateDescriptionFragmentImpl.java
Outdated
Show resolved
Hide resolved
...openhab.core/src/main/java/org/openhab/core/internal/types/StateDescriptionFragmentImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: [email protected] <[email protected]>
There was a problem hiding this comment.
I would actually prefer Objects.hashCode() over Objects.hash()....
Using hash() will change the value, compared to what we had before:
https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/util/Objects.html#hash(java.lang.Object...)
(not sure if this is relevant for this class, but we might run into trouble with persisted data)
Signed-off-by: [email protected] <[email protected]>
Done @holgerfriedrich |
bundles/org.openhab.core/src/main/java/org/openhab/core/internal/service/WatchServiceImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: [email protected] <[email protected]>
holgerfriedrich
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Focused on "Potential null pointer access". Minus 64 warnings