Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove orbit bundles from runtime-pom #3566

Closed
wants to merge 1 commit into from
Closed

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Apr 21, 2023

They are not available on Maven Central and generate warning during the build.

@wborn
Copy link
Member

wborn commented Apr 21, 2023

That would be nice but as you can see the artifacts on Maven Central do not work as well as the Orbit bundles.
To get rid of the warnings just create some POMs and Kai should be able to upload those to Artifactory as well.
There are also also some missing POMs for some add-on deps, see openhab/openhab-addons#11524.

@J-N-K
Copy link
Member Author

J-N-K commented Apr 21, 2023

It's essentially the same problem we saw in #3321: The xtext guys use Require-Bundle headers instead of Import-Package, and they require e.g. io.github.classgraph while the non-orbit bundle has a BSN io.github.classgraph.classgraph.

Maybe we should really re-package the xtext bundles and use Import-Package instead of Require-Bundle headers. This will also help us with the equninox/felix issue.

@wborn
Copy link
Member

wborn commented Jan 4, 2024

Maybe just create and upload the POMs to fix the missing POM warnings instead of waiting for OSGi compatible artifacts to be released to Maven Central?

@wborn wborn added work in progress A PR that is not yet ready to be merged awaiting feedback labels Jan 16, 2024
@J-N-K J-N-K closed this Mar 27, 2024
@J-N-K J-N-K deleted the orbit branch May 1, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting feedback work in progress A PR that is not yet ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants