Allow for mobile app or web services to retrieve proxy URL to access MainUI #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MainUI Signed-off-by: Felix Lo <[email protected]>
|
@digitaldan please take a look and comment . Tq |
|
Apologies , i got busy then left town for a little while. This looks reasonable to me, I want to take a look also at the IOS app and see if we can integrate this into the central network tracker logic, once we have that flushed out and working, might be a good idea to let the Android devs know as well. Let me take a closer look this week when i return. Thanks! |
|
@digitaldan how is this ? Should we proceed? |
digitaldan
added a commit
to digitaldan/openhab-cloud
that referenced
this pull request
May 24, 2024
see openhab#440 Signed-off-by: Dan Cunningham <[email protected]>
|
Hi sorry about leaving this for so long. Since i was in the code for another PR, i was hoping to merge this is, but i needed to make some changes to it. I have another PR #452 with those changes, do you mind if i merge that one in instead? |
digitaldan
added a commit
that referenced
this pull request
May 25, 2024
* Add proxy URL (thanks to @lsafelix75 for the original PR) see #440 Signed-off-by: Dan Cunningham <[email protected]> * Quick change of middleware order Signed-off-by: Dan Cunningham <[email protected]> * Use single ticks Signed-off-by: Dan Cunningham <[email protected]> --------- Signed-off-by: Dan Cunningham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to openhab/openhab-ios#729
Signed-off-by: Felix Lo [email protected]