Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Travis matrix for multiple emulators #645

Closed
wants to merge 6 commits into from

Conversation

mueller-ma
Copy link
Member

@FlorianSW I just want to see if api 14 works without messing up your PR.

If it works I can either merge this one and you make a new one, or you include this change in #611

FlorianSW and others added 5 commits January 5, 2018 18:48
Getting the Voice recognition running is only possible, if at least one
handler handles the RecognitionService.SERVICE_INTERFACE intent. The
easiest way to achive this is to run the instrumented test on an emulator
which actually has the Google Play services installed.

This commit changes the travis-ci configuration so that the emulator
started has the Play services installed. It also adds some extras, which
are already pre-installed, but accoridng to the travis documentation[1]
should be explicitly mentioned to ensure build stability. However, for the
current build they don't change anything. The extras are namely:

extra-android-support
extra-google-google_play_services
extra-google-m2repository
extra-android-m2repository

For some reason, also the -no-audio switch does not work anymore, however,
currently there's no need to completely disable audio in our build and
test.

[1]
https://docs.travis-ci.com/user/languages/android/#Pre-installed-components

Signed-off-by: Florian <[email protected]>
android-27 can not be run on travis, as there's no arm abi anymore, and
x86 requires KVM support, which is not possible in travis containers atm,
see travis-ci/travis-ci#1419

Use latest android image provided by travis (which has an arm abi),
android-25, and also does not have a non-google-apis image anymore.

Signed-off-by: Florian <[email protected]>
Signed-off-by: mueller-ma <[email protected]>
@mueller-ma mueller-ma added the automation Everything related to Bots label Jan 14, 2018
@mueller-ma mueller-ma closed this Jan 14, 2018
@mueller-ma mueller-ma reopened this Jan 14, 2018
@codecov
Copy link

codecov bot commented Jan 14, 2018

Codecov Report

Merging #645 into master will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #645      +/-   ##
==========================================
+ Coverage   31.36%   31.53%   +0.16%     
==========================================
  Files          64       64              
  Lines        4903     4903              
  Branches      658      658              
==========================================
+ Hits         1538     1546       +8     
+ Misses       3144     3136       -8     
  Partials      221      221
Impacted Files Coverage Δ
...openhab/habdroid/ui/OpenHABWidgetListFragment.java 51.36% <0%> (+0.34%) ⬆️
.../org/openhab/habdroid/ui/OpenHABWidgetAdapter.java 42.56% <0%> (+1.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 694c9c5...24b1d3f. Read the comment docs.

@FlorianSW
Copy link
Member

@mueller-ma feel free to add it to my existing PR. However, your changes still skip the voice test, so this problem is not resolved with that.

@mueller-ma
Copy link
Member Author

I wonder why the tests pass for api 16. I run kitkat on an avd and that crashed instantly due to a multidex issue (#619)

@mueller-ma
Copy link
Member Author

Ok, the test fails with api 19, but not with api 16. I have checked my fix #619 on an avd, so I'm going to merge that one.

@FlorianSW I'm going to add api 19 to your PR.

@mueller-ma mueller-ma closed this Jan 15, 2018
@mueller-ma mueller-ma deleted the travis-matrix2 branch January 15, 2018 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Everything related to Bots
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants