Add codecov and run android tests via travis #526

mueller-ma · 2017-12-14T17:06:40Z

See this PR for an example: https://github.com/mueller-ma-bot/openhab.android/pull/1
I also tested Sputnik there, but this is not included in this PR.

@digitaldan This is just the config for codecov. To add it, go to their website and login via github.

Hopefully this will help to increase the code coverage. Current is ~6%

codecov-io · 2017-12-14T17:15:49Z

Codecov Report

❗ No coverage uploaded for pull request base (master@c31e282). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #526   +/-   ##
=========================================
  Coverage          ?   31.86%           
=========================================
  Files             ?       64           
  Lines             ?     4852           
  Branches          ?      655           
=========================================
  Hits              ?     1546           
  Misses            ?     3087           
  Partials          ?      219

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c31e282...5ac28fb. Read the comment docs.

mueller-ma · 2018-01-01T16:48:54Z

Travis build failed because of the failing espresso ui test. Fix is in #584
https://travis-ci.org/openhab/openhab.android/builds/323801074

kaikreuzer · 2018-01-01T17:05:03Z

@mueller-ma Only the links to old Travis jobs are now broken - new ones are already correct as you can see on https://travis-ci.org/openhab/openhab-android

FlorianSW · 2018-01-01T22:14:01Z

So, I've run the same test suite locally and it succeeded. However, I used api level 27, travis uses 22 (I assume this is intentional?), however, this shouldn't make any difference.

On the other hand, when running master, I also have only 4 tests:
Starting 4 tests on Nexus_5X_API_26(AVD) - 8.0.0
travis runs 5:
Starting 5 tests on test(AVD) - 5.1.1

And org.openhab.habdroid.ui.BasicWidgetTest > openHABMainActivityTest[test(AVD) - 5.1.1] FAILED
android.support.test.espresso.NoMatchingViewException: No views in hierarchy found matching: (with id: android:id/text1 and with text: is "demo" and Child at position 0 in parent (an instance of android.widget.ListView and Child at position 0 in parent an instance of android.widget.FrameLayout) and is displayed on the screen to the user)

should've failed for 2 other tests, too, if there's really no demo sitemap. I currently rerun the tests with 5.1.1 and will checkout this pull request to maybe get it reproduced locally :)

mueller-ma · 2018-01-01T22:38:51Z

travis uses 22 (I assume this is intentional?)

I'm planning to create a build matrix in a different PR after this one is merged. Than tests run on multiple APIs.

FlorianSW · 2018-01-01T22:41:03Z

Ok, so running the same test suite on Android 5.1.1, the view Hierarchy is slightly different. That's what you get on API level 27 currently:

View Hierarchy:
+>DecorView{id=-1, visibility=VISIBLE, width=1024, height=496, has-focus=true, has-focusable=true, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=false, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0, child-count=1}
|
+->FrameLayout{id=-1, visibility=VISIBLE, width=940, height=412, has-focus=true, has-focusable=true, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=false, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=42.0, y=42.0, child-count=2}
|
+-->FrameLayout{id=16908290, res-name=content, visibility=VISIBLE, width=940, height=412, has-focus=true, has-focusable=true, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=false, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0, child-count=1}
|
+--->AlertDialogLayout{id=16909134, res-name=parentPanel, visibility=VISIBLE, width=940, height=412, has-focus=true, has-focusable=true, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=false, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0, child-count=4}
|
+---->LinearLayout{id=16909382, res-name=topPanel, visibility=VISIBLE, width=940, height=139, has-focus=false, has-focusable=false, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=false, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0, child-count=2}
|
+----->LinearLayout{id=16909372, res-name=title_template, visibility=VISIBLE, width=940, height=118, has-focus=false, has-focusable=false, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=false, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0, child-count=2}
|
+------>AppCompatImageView{id=16908294, res-name=icon, visibility=GONE, width=0, height=0, has-focus=false, has-focusable=false, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=true, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0}
|
+------>DialogTitle{id=16908696, res-name=alertTitle, visibility=VISIBLE, width=814, height=71, has-focus=false, has-focusable=false, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=false, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=63.0, y=47.0, text=Select default sitemap, input-type=0, ime-target=false, has-links=false}
|
+----->Space{id=16909367, res-name=titleDividerNoCustom, visibility=VISIBLE, width=940, height=21, has-focus=false, has-focusable=false, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=false, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=118.0}
|
+---->FrameLayout{id=16908800, res-name=contentPanel, visibility=VISIBLE, width=940, height=273, has-focus=true, has-focusable=true, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=false, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=139.0, child-count=1}
|
+----->RecycleListView{id=16909239, res-name=select_dialog_listview, visibility=VISIBLE, width=940, height=273, has-focus=true, has-focusable=true, has-window-focus=true, is-clickable=true, is-enabled=true, is-focused=true, is-focusable=true, is-layout-requested=false, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0, child-count=2}
|
+------>AppCompatTextView{id=16908308, res-name=text1, visibility=VISIBLE, width=940, height=126, has-focus=false, has-focusable=false, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=false, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0, text=demo, input-type=0, ime-target=false, has-links=false}
|
+------>AppCompatTextView{id=16908308, res-name=text1, visibility=VISIBLE, width=940, height=126, has-focus=false, has-focusable=false, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=false, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=126.0, text=_default, input-type=0, ime-target=false, has-links=false}
|
+---->FrameLayout{id=16908807, res-name=customPanel, visibility=GONE, width=0, height=0, has-focus=false, has-focusable=false, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=true, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0, child-count=1}
|
+----->FrameLayout{id=16908331, res-name=custom, visibility=VISIBLE, width=0, height=0, has-focus=false, has-focusable=false, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=true, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0, child-count=0}
|
+---->ScrollView{id=16908756, res-name=buttonPanel, visibility=GONE, width=0, height=0, has-focus=false, has-focusable=false, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=true, is-layout-requested=true, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0, child-count=1}
|
+----->ButtonBarLayout{id=-1, visibility=VISIBLE, width=0, height=0, has-focus=false, has-focusable=false, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=true, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0, child-count=4}
|
+------>AppCompatButton{id=16908315, res-name=button3, visibility=GONE, width=0, height=0, has-focus=false, has-focusable=false, has-window-focus=true, is-clickable=true, is-enabled=true, is-focused=false, is-focusable=true, is-layout-requested=true, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0, text=, input-type=0, ime-target=false, has-links=false}
|
+------>Space{id=16909290, res-name=spacer, visibility=INVISIBLE, width=0, height=0, has-focus=false, has-focusable=false, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=true, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0}
|
+------>AppCompatButton{id=16908314, res-name=button2, visibility=GONE, width=0, height=0, has-focus=false, has-focusable=false, has-window-focus=true, is-clickable=true, is-enabled=true, is-focused=false, is-focusable=true, is-layout-requested=true, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0, text=, input-type=0, ime-target=false, has-links=false}
|
+------>AppCompatButton{id=16908313, res-name=button1, visibility=GONE, width=0, height=0, has-focus=false, has-focusable=false, has-window-focus=true, is-clickable=true, is-enabled=true, is-focused=false, is-focusable=true, is-layout-requested=true, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0, text=, input-type=0, ime-target=false, has-links=false}
|
+-->ViewStub{id=16908678, res-name=action_mode_bar_stub, visibility=GONE, width=0, height=0, has-focus=false, has-focusable=false, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=true, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0}
|

And that's what you get on API level 22:

View Hierarchy:
+>DecorView{id=-1, visibility=VISIBLE, width=1026, height=496, has-focus=true, has-focusable=true, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=false, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0, child-count=1}
|
+->FrameLayout{id=-1, visibility=VISIBLE, width=942, height=412, has-focus=true, has-focusable=true, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=false, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=42.0, y=42.0, child-count=2}
|
+-->FrameLayout{id=16908290, res-name=content, visibility=VISIBLE, width=942, height=412, has-focus=true, has-focusable=true, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=false, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0, child-count=1}
|
+--->LinearLayout{id=16908990, res-name=parentPanel, visibility=VISIBLE, width=942, height=412, has-focus=true, has-focusable=true, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=false, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0, child-count=4}
|
+---->LinearLayout{id=16908991, res-name=topPanel, visibility=VISIBLE, width=942, height=118, has-focus=false, has-focusable=false, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=false, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0, child-count=1}
|
+----->LinearLayout{id=16908992, res-name=title_template, visibility=VISIBLE, width=942, height=118, has-focus=false, has-focusable=false, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=false, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0, child-count=2}
|
+------>AppCompatImageView{id=16908294, res-name=icon, visibility=GONE, width=0, height=0, has-focus=false, has-focusable=false, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=true, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0}
|
+------>DialogTitle{id=16908993, res-name=alertTitle, visibility=VISIBLE, width=816, height=71, has-focus=false, has-focusable=false, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=false, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=63.0, y=47.0, text=Select default sitemap, input-type=0, ime-target=false, has-links=false}
|
+---->FrameLayout{id=16908998, res-name=contentPanel, visibility=VISIBLE, width=942, height=294, has-focus=true, has-focusable=true, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=false, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=118.0, child-count=3}
|
+----->View{id=16909003, res-name=scrollIndicatorUp, visibility=INVISIBLE, width=942, height=3, has-focus=false, has-focusable=false, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=false, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0}
|
+----->RecycleListView{id=16909195, res-name=select_dialog_listview, visibility=VISIBLE, width=942, height=294, has-focus=true, has-focusable=true, has-window-focus=true, is-clickable=true, is-enabled=true, is-focused=true, is-focusable=true, is-layout-requested=false, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0, child-count=2}
|
+------>AppCompatTextView{id=16908308, res-name=text1, visibility=VISIBLE, width=942, height=126, has-focus=false, has-focusable=false, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=false, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=21.0, text=demo, input-type=0, ime-target=false, has-links=false}
|
+------>AppCompatTextView{id=16908308, res-name=text1, visibility=VISIBLE, width=942, height=126, has-focus=false, has-focusable=false, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=false, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=147.0, text=_default, input-type=0, ime-target=false, has-links=false}
|
+----->View{id=16909005, res-name=scrollIndicatorDown, visibility=INVISIBLE, width=942, height=3, has-focus=false, has-focusable=false, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=false, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=291.0}
|
+---->FrameLayout{id=16909000, res-name=customPanel, visibility=GONE, width=0, height=0, has-focus=false, has-focusable=false, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=true, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0, child-count=1}
|
+----->FrameLayout{id=16908331, res-name=custom, visibility=VISIBLE, width=0, height=0, has-focus=false, has-focusable=false, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=true, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0, child-count=0}
|
+---->LinearLayout{id=16908995, res-name=buttonPanel, visibility=GONE, width=0, height=0, has-focus=false, has-focusable=false, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=true, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0, child-count=4}
|
+----->AppCompatButton{id=16908315, res-name=button3, visibility=GONE, width=0, height=0, has-focus=false, has-focusable=false, has-window-focus=true, is-clickable=true, is-enabled=true, is-focused=false, is-focusable=true, is-layout-requested=true, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0, text=, input-type=0, ime-target=false, has-links=false}
|
+----->Space{id=-1, visibility=INVISIBLE, width=0, height=0, has-focus=false, has-focusable=false, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=true, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0}
|
+----->AppCompatButton{id=16908314, res-name=button2, visibility=GONE, width=0, height=0, has-focus=false, has-focusable=false, has-window-focus=true, is-clickable=true, is-enabled=true, is-focused=false, is-focusable=true, is-layout-requested=true, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0, text=, input-type=0, ime-target=false, has-links=false}
|
+----->AppCompatButton{id=16908313, res-name=button1, visibility=GONE, width=0, height=0, has-focus=false, has-focusable=false, has-window-focus=true, is-clickable=true, is-enabled=true, is-focused=false, is-focusable=true, is-layout-requested=true, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0, text=, input-type=0, ime-target=false, has-links=false}
|
+-->ViewStub{id=16909171, visibility=GONE, width=0, height=0, has-focus=false, has-focusable=false, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=true, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0}
|

So, both AppCompatTextView with the demo sitemap in it are wrapped by a RecycleListView, where "demo" ist the first child element. Then comes the different. While API level 27 wrpas this recyclclistview directly into a FrameLayout, api level 22 puts an invisible View with the res scrollIndicatorUp as the first element of the wrapping FrameLout:
View{id=16909003, res-name=scrollIndicatorUp, visibility=INVISIBLE, width=942, height=3, has-focus=false, has-focusable=false, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=false, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0}

So, the structure is slightly different, but the position of the demo is not 0 in api level 22 anymore, but 1. I think we can work around this by simply asserting, that demo is there and wrapped by a recycle list view?

mueller-ma · 2018-01-01T23:02:28Z

Yes, we can do that. All the atChild() are autogenerated by the espresso test recorder.

FlorianSW · 2018-01-01T23:09:44Z

See #592

mueller-ma · 2018-01-03T18:18:25Z

@FlorianSW Tests are still failing

FlorianSW · 2018-01-03T21:25:30Z

They're not failing for me locally. Can you check that, too?

mueller-ma · 2018-01-04T20:24:59Z

Also works for me locally via Android Studio.
Rebuild travis...

mueller-ma · 2018-01-04T21:35:37Z

Ran it again and now only one test failes with No views in hierarchy found matching: (with id: org.openhab.habdroid:id/mainmenu_voice_recognition and with content description: is "Voice recognition" and is displayed on the screen to the user). Is it possible that the abi has no gapps?

FlorianSW · 2018-01-04T22:40:48Z

Hmm, possible. I'll submit a PR shortly, which will extract this test from the BasicWidgetTest (as it's not a widget test at all, and it makes it easier to skip it), which checks, if Voice recognition is supported/available on the device before running the test suite. With that we can make sure, that voice service is really not available on the AVD and probably change that in some way.

FlorianSW · 2018-01-04T22:44:09Z

.travis.yml

 android:
  components:
  - tools
  - build-tools-25.0.2
  - platform-tools
  - tools
+  - android-22
+  - sys-img-armeabi-v7a-android-22


What about adding some extras, which should probably enable voice recognition? However, this is not based on facts, just an idea :P I'm also not sure, which of these extras are already included :/ Also: We should first somehow make sure, that it's related to the play services :D

- extra-google-google_play_services - extra-google-m2repository - extra-android-m2repository - extra-android-support

Can we somehow check a build with these extras to see, if the voice recognition test is still skipped?

FlorianSW · 2018-01-04T22:56:15Z

PR I mean: #609

Signed-off-by: mueller-ma <[email protected]>

FlorianSW · 2018-01-04T23:37:27Z

org.openhab.habdroid.ui.BasicWidgetTest > openHABMainActivityTest[test(AVD) - 5.1.1] FAILED 
	android.support.test.espresso.NoMatchingViewException: No views in hierarchy found matching: (with id: org.openhab.habdroid:id/colorbutton_color and is displayed on the screen to the user)
	If the target view is not part of the view hierarchy, you may need to use Espresso.onData to load it from one of the following AdapterViews:android.widget.ListView{183a0a3 IFED.VC. ......ID -480,0-0,678 #7f090084 app:id/left_drawer}
org.openhab.habdroid.ui.VoiceRecognitionTest > checkVoiceAvailbility[test(AVD) - 5.1.1] SKIPPED 
	org.junit.AssumptionViolatedException: Voice recognition not available, skipping tests for it.
	at org.junit.Assume.assumeTrue(Assume.java:59)
:mobile:connectedFossDebugAndroidTest FAILED

FlorianSW · 2018-01-05T00:11:27Z

Ok, could it be possible, that the colorpicker simply isn't in the view of the user? The colorpicker check uses a ViewInteraction to check, if it is display, instead of looking at the data and checking, that the picker is present. So, when a device, let's say WVGA with 480x800[1] pixel, the colorpicker is not in the view when navigating to the Widget Overview (selecting Widget Overview, btw., wouldn't pass the isDisplayedcheck, too, however, it already uses a data interaction to click on an element, which is not visible to the user already). This is the only thing I can think of at the moment.

[1] Which is, what travis booted up:

$ android list target
Available Android targets:
----------
id: 1 or "android-22"
     Name: Android 5.1.1
     Type: Platform
     API level: 22
     Revision: 2
     Skins: HVGA, QVGA, WQVGA400, WQVGA432, WSVGA, **WVGA800 (default)**, WVGA854, WXGA720, WXGA800, WXGA800-7in
 Tag/ABIs : default/armeabi-v7a
----------
id: 2 or "android-25"
     Name: Android 7.1.1
     Type: Platform
     API level: 25
     Revision: 3
     Skins: HVGA, QVGA, WQVGA400, WQVGA432, WSVGA, **WVGA800 (default)**, WVGA854, WXGA720, WXGA800, WXGA800-7in
 Tag/ABIs : no ABIs.

mueller-ma · 2018-01-05T12:27:33Z

@kaikreuzer Can you use @openhab-bot to add this repo on https://codecov.io/ ?

kaikreuzer · 2018-01-05T12:39:24Z

I've logged in as openhab-bot and granted access to Github to codecov. When being logged in, I can see the page https://codecov.io/gh/openhab/openhab-android.
What else do I need to do?

mueller-ma · 2018-01-05T12:50:11Z

Nothing, I'm going to merge this PR when we resolved the failing ci.

mueller-ma · 2018-01-05T13:15:32Z

CI succeeds now: https://travis-ci.org/openhab/openhab-android/builds/325431126?utm_source=github_status&utm_medium=notification

FlorianSW · 2018-01-05T14:59:58Z

.travis.yml

+# Emulator Management: Create, Start and Wait
+before_script:
+- android list device
+- echo no | android create avd --force -n test -t android-22 --abi armeabi-v7a -d "5.4in FWVGA"


Hmm, this doesn't solve the problem itself, it just works around it :/ What happens, if the demo sitemap changes slightly and the widgets we use in this test are again outside of the view?

Is there a check for "exists, but not visible"?

It seems there isn't :/ Then this should be fine for now :D

mueller-ma · 2018-01-05T22:41:26Z

@kaikreuzer Can you check if codecov is setup correctly? On my fork, where I activeted it, codecov shows up a github check: https://github.com/mueller-ma-bot/openhab.android/pull/1
But here it doesnt: #612

kaikreuzer · 2018-01-07T20:45:15Z

@mueller-ma I've just checked: The webhook wasn't yet created, I have done so now.
Hopefully you will see codecov checks on PRs now!

mueller-ma · 2018-01-08T04:54:43Z

Ok, we will see.

mueller-ma · 2018-01-09T18:03:50Z

#619 is a new PR, but it doesnt have the codecov check. Maybe you try to install codecov again via https://github.com/integration/codecov

kaikreuzer · 2018-01-10T09:02:03Z

Installing it that way isn't possible:

Note that openhab-bot does not own any repos. If I create a fork of openhab-android, I can enable it there, but that obviously won't help us.
As you can see on https://github.com/openhab/openhab-android/settings/hooks/19744585, the webhook is active and successfully delivered to codecov.io, so I would have expected that reacts on those (the webhook also has the right to push state information)...

mueller-ma · 2018-01-10T15:26:22Z

Can you set @openhab-bot as team bot?

kaikreuzer · 2018-01-10T16:33:41Z

I've now installed the official Github integration as myself to the org account and activated it on this repo - I hope this now works!

mueller-ma added the automation Everything related to Bots label Dec 14, 2017

mueller-ma requested a review from digitaldan December 14, 2017 17:06

mueller-ma closed this Jan 1, 2018

mueller-ma reopened this Jan 1, 2018

mueller-ma closed this Jan 1, 2018

mueller-ma reopened this Jan 1, 2018

mueller-ma changed the title ~~Add codecov~~ Add codecov and run android tests via travis Jan 1, 2018

This was referenced Jan 1, 2018

Make BasicWidgetTest working again #584

Merged

Make instrumentation tests more independant from each other #591

Merged

mueller-ma closed this Jan 4, 2018

mueller-ma reopened this Jan 4, 2018

FlorianSW reviewed Jan 4, 2018

View reviewed changes

mueller-ma added 2 commits January 5, 2018 00:09

Add codecov

ddae1d0

Signed-off-by: mueller-ma <[email protected]>

Run emulator

9870bde

Signed-off-by: mueller-ma <[email protected]>

mueller-ma mentioned this pull request Jan 5, 2018

Use sitemap labels instead of name in the sitemap selection dialog #597

Merged

Use Pixel XL

b32c6a7

android list device

b78a5c3

mueller-ma added 2 commits January 5, 2018 13:52

Update .travis.yml

5ac28fb

Update .travis.yml

df4b814

mueller-ma merged commit 3d35de5 into openhab:master Jan 5, 2018

mueller-ma deleted the codecov-local branch January 5, 2018 13:14

FlorianSW reviewed Jan 5, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add codecov and run android tests via travis #526

Add codecov and run android tests via travis #526

mueller-ma commented Dec 14, 2017

codecov-io commented Dec 14, 2017 •

edited

Loading

mueller-ma commented Jan 1, 2018

kaikreuzer commented Jan 1, 2018

FlorianSW commented Jan 1, 2018

mueller-ma commented Jan 1, 2018

FlorianSW commented Jan 1, 2018

mueller-ma commented Jan 1, 2018

FlorianSW commented Jan 1, 2018

mueller-ma commented Jan 3, 2018

FlorianSW commented Jan 3, 2018

mueller-ma commented Jan 4, 2018

mueller-ma commented Jan 4, 2018

FlorianSW commented Jan 4, 2018

FlorianSW Jan 4, 2018

FlorianSW Jan 5, 2018

FlorianSW commented Jan 4, 2018

FlorianSW commented Jan 4, 2018

FlorianSW commented Jan 5, 2018

mueller-ma commented Jan 5, 2018

kaikreuzer commented Jan 5, 2018

mueller-ma commented Jan 5, 2018

mueller-ma commented Jan 5, 2018

FlorianSW Jan 5, 2018

mueller-ma Jan 5, 2018

FlorianSW Jan 5, 2018

mueller-ma commented Jan 5, 2018

kaikreuzer commented Jan 7, 2018

mueller-ma commented Jan 8, 2018

mueller-ma commented Jan 9, 2018

kaikreuzer commented Jan 10, 2018

mueller-ma commented Jan 10, 2018 •

edited

Loading

kaikreuzer commented Jan 10, 2018

Add codecov and run android tests via travis #526

Add codecov and run android tests via travis #526

Conversation

mueller-ma commented Dec 14, 2017

codecov-io commented Dec 14, 2017 • edited Loading

Codecov Report

mueller-ma commented Jan 1, 2018

kaikreuzer commented Jan 1, 2018

FlorianSW commented Jan 1, 2018

mueller-ma commented Jan 1, 2018

FlorianSW commented Jan 1, 2018

mueller-ma commented Jan 1, 2018

FlorianSW commented Jan 1, 2018

mueller-ma commented Jan 3, 2018

FlorianSW commented Jan 3, 2018

mueller-ma commented Jan 4, 2018

mueller-ma commented Jan 4, 2018

FlorianSW commented Jan 4, 2018

FlorianSW Jan 4, 2018

Choose a reason for hiding this comment

FlorianSW Jan 5, 2018

Choose a reason for hiding this comment

FlorianSW commented Jan 4, 2018

FlorianSW commented Jan 4, 2018

FlorianSW commented Jan 5, 2018

mueller-ma commented Jan 5, 2018

kaikreuzer commented Jan 5, 2018

mueller-ma commented Jan 5, 2018

mueller-ma commented Jan 5, 2018

FlorianSW Jan 5, 2018

Choose a reason for hiding this comment

mueller-ma Jan 5, 2018

Choose a reason for hiding this comment

FlorianSW Jan 5, 2018

Choose a reason for hiding this comment

mueller-ma commented Jan 5, 2018

kaikreuzer commented Jan 7, 2018

mueller-ma commented Jan 8, 2018

mueller-ma commented Jan 9, 2018

kaikreuzer commented Jan 10, 2018

mueller-ma commented Jan 10, 2018 • edited Loading

kaikreuzer commented Jan 10, 2018

codecov-io commented Dec 14, 2017 •

edited

Loading

mueller-ma commented Jan 10, 2018 •

edited

Loading