[persistence] Implement HistoricItem.getInstant #17578
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joerg1985
force-pushed
the
historic-get-instant
branch
2 times, most recently
from
9ac107d
to
2f1c724
Compare
lsiepel
added
the
enhancement
lsiepel
reviewed
Oct 21, 2024
...e.dynamodb/src/main/java/org/openhab/persistence/dynamodb/internal/DynamoDBHistoricItem.java
Show resolved
Hide resolved
...e.influxdb/src/main/java/org/openhab/persistence/influxdb/internal/InfluxDBHistoricItem.java
Show resolved
Hide resolved
lsiepel
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Thanks, LGTM.
As i don't expect you to have tested all different persistences services and the the effects can be huge for users, i like to ask @jlaur to also look at this. For both his experience on persistence and datetime handling.
jlaur
approved these changes
Oct 21, 2024
|
Re dynamodb, there is quite extensive tests in CI if running locally with correct env variables, it can also test against live dynamodb of course if CI is run using UTC, it might not reveal all the bugs |
|
@joerg1985 can you resolve the conflicts? |
Signed-off-by: Jörg Sautter <[email protected]>
joerg1985
force-pushed
the
historic-get-instant
branch
from
2f1c724
to
08a6422
Compare
|
@lsiepel i have rebased the branch and fixed the conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does implement the new
HistoricItem.getInstantmethod from PR openhab/openhab-core#4384 for persistence implementations.