Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Freeboxos] New binding alternative to Freebox binding #12342

Merged
merged 91 commits into from
Jul 5, 2023
Merged
Changes from 1 commit
Commits
Show all changes
91 commits
Select commit Hold shift + click to select a range
fc0aad1
SAT warnings handling
clinique Feb 23, 2022
1533cbf
Correcting potential NPE
clinique Mar 12, 2022
56f45e2
Correcting a NPE on error
clinique Mar 15, 2022
8884e2e
Active player request falls to incorrect API version
clinique Mar 18, 2022
990cf26
Reintroducing missing capability to send keys to player.
clinique Apr 5, 2022
db1dd67
Handling DUTY CYCLE more gracefully
clinique Jul 1, 2022
b964e45
Enhancing DUTY CYCLE
clinique Jul 4, 2022
ad5ec97
Moving to SNAPSHOT 3.4
clinique Jul 23, 2022
40ce57f
Adress inconsistencies in binding name
clinique Jul 24, 2022
5ddb78a
Discover Freebox Delta Home equipments(basic_shutter)
ben12 Aug 21, 2022
f8e5aff
Clean previous test code
ben12 Aug 23, 2022
c1e9fb3
Fix "Unexpected command"
ben12 Aug 23, 2022
e23ae88
Fix thing comm error
ben12 Aug 26, 2022
08196f0
README for basic shutter
ben12 Aug 29, 2022
e6d77f1
Fix MR discusions and solve maven check errors and warnings
ben12 Sep 1, 2022
8dc8d93
Fix MR discusions
ben12 Sep 1, 2022
81469e5
Fix README.md
ben12 Sep 1, 2022
d58bb3e
Enhancing logging to indentify source of erratic warn
clinique Nov 11, 2022
cb32b42
Deny polling a device data when its API is needed and it is OFFLINE
clinique Dec 22, 2022
9b3dd72
Taking #11833 in accound
clinique Dec 24, 2022
815643d
Switching to Snapshot 4.0.0
clinique Dec 29, 2022
7e1a2df
Implementing SHUTTER Home Node
clinique Dec 29, 2022
f437308
Saving work before instroduction of ArrayListDeserializer
clinique Jan 13, 2023
376de7b
Enhanced deserialization to simplify code
clinique Jan 16, 2023
1338f19
Switching to Java 17 records
clinique Jan 20, 2023
b0fcb9a
Switching to addons.xml, headers updated
clinique Jan 20, 2023
54c0821
Correcting two errors.
clinique Jan 20, 2023
5402d26
Enhance usage of global variables
clinique Jan 21, 2023
fdf9368
Some code enhancement for base classes
clinique Jan 21, 2023
48d259e
solving SAT issues
clinique Jan 21, 2023
c18dd67
Adding IliadBox compatibility
clinique Feb 10, 2023
0f86e03
Commiting work
clinique Feb 12, 2023
6c9028c
Saving work
clinique Feb 14, 2023
3880b77
Rebooting Home Node part
clinique Feb 16, 2023
c2877a8
Spotless apply
clinique Feb 16, 2023
4f7aa82
Adding i18n
clinique Mar 9, 2023
a320471
Decreasing websocket logging level
clinique Apr 24, 2023
83060e5
SAT warnings handling
clinique Feb 23, 2022
4802a15
Correcting potential NPE
clinique Mar 12, 2022
1003584
Correcting a NPE on error
clinique Mar 15, 2022
38178f3
Active player request falls to incorrect API version
clinique Mar 18, 2022
74c99cc
Reintroducing missing capability to send keys to player.
clinique Apr 5, 2022
6d868b5
Handling DUTY CYCLE more gracefully
clinique Jul 1, 2022
d54a254
Enhancing DUTY CYCLE
clinique Jul 4, 2022
f5a049e
Moving to SNAPSHOT 3.4
clinique Jul 23, 2022
7280ac4
Adress inconsistencies in binding name
clinique Jul 24, 2022
7b0b790
Discover Freebox Delta Home equipments(basic_shutter)
ben12 Aug 21, 2022
a328839
Clean previous test code
ben12 Aug 23, 2022
52b9ac2
Fix "Unexpected command"
ben12 Aug 23, 2022
a6e57bc
Fix thing comm error
ben12 Aug 26, 2022
814deab
README for basic shutter
ben12 Aug 29, 2022
8728703
Fix MR discusions and solve maven check errors and warnings
ben12 Sep 1, 2022
0bdfc0d
Fix MR discusions
ben12 Sep 1, 2022
6809d6d
Fix README.md
ben12 Sep 1, 2022
23ead80
Enhancing logging to indentify source of erratic warn
clinique Nov 11, 2022
f12259c
Deny polling a device data when its API is needed and it is OFFLINE
clinique Dec 22, 2022
564e07a
Taking #11833 in accound
clinique Dec 24, 2022
df778a2
Switching to Snapshot 4.0.0
clinique Dec 29, 2022
4e1b84d
Implementing SHUTTER Home Node
clinique Dec 29, 2022
bab969a
Saving work before instroduction of ArrayListDeserializer
clinique Jan 13, 2023
29f1499
Enhanced deserialization to simplify code
clinique Jan 16, 2023
0e70eed
Switching to Java 17 records
clinique Jan 20, 2023
b4177dd
Switching to addons.xml, headers updated
clinique Jan 20, 2023
29270ae
Correcting two errors.
clinique Jan 20, 2023
c6edc35
Enhance usage of global variables
clinique Jan 21, 2023
c669dd8
Some code enhancement for base classes
clinique Jan 21, 2023
d8f7331
solving SAT issues
clinique Jan 21, 2023
dcb36b0
Adding IliadBox compatibility
clinique Feb 10, 2023
cb2d7e7
Commiting work
clinique Feb 12, 2023
bfa9e1f
Saving work
clinique Feb 14, 2023
0e6b3f2
Rebooting Home Node part
clinique Feb 16, 2023
9618d06
Spotless apply
clinique Feb 16, 2023
8ba0271
Enhancing SAT report
clinique Apr 24, 2023
efd7c3e
I think that mvn spotless:apply has a problem with records - trying o…
clinique Apr 24, 2023
2fcba0a
Avoid requesting detailed information for a shutdown repeater.
clinique Apr 28, 2023
f638cb0
Switched fan speed to RPM unit
clinique May 23, 2023
fc920d5
Correcting SAT
clinique May 23, 2023
905a671
Correcting SAT
clinique May 23, 2023
e3137db
Divergence between eclipse and mvn spotless:apply
clinique May 23, 2023
50991bc
YASAT
clinique May 23, 2023
c3e9434
Corrections following fwolter code review
clinique Jun 21, 2023
bd41053
Pleasing SAT
clinique Jun 21, 2023
14adc08
Second fwolter code review
clinique Jun 22, 2023
df30151
Porting modifications introduced in PR #15121
clinique Jun 22, 2023
d9712cc
Removing redundant null checks.
clinique Jun 26, 2023
e07249f
Rebased.
clinique Jun 26, 2023
f05d318
Trying to remove the last sleep.
clinique Jun 30, 2023
76f82f1
Reporting modifications of PR #15121
clinique Jul 2, 2023
dabbc2f
Reverting to working and cleaner granting process
clinique Jul 2, 2023
4a6e835
Removing last Thread:Sleep
clinique Jul 4, 2023
adeb086
spotless:apply
clinique Jul 4, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Enhancing DUTY CYCLE
Signed-off-by: clinique <gael@lhopital.org>
clinique committed Jun 26, 2023
commit d54a2546c37fd238e91dc785d679841c51263ec6
2 changes: 1 addition & 1 deletion bundles/org.openhab.binding.freeboxos/pom.xml
Original file line number Diff line number Diff line change
@@ -35,7 +35,7 @@
<parent>
<groupId>org.openhab.addons.bundles</groupId>
<artifactId>org.openhab.addons.reactor.bundles</artifactId>
<version>3.3.0-SNAPSHOT</version>
<version>3.4.0-SNAPSHOT</version>
</parent>

<artifactId>org.openhab.binding.freeboxos</artifactId>
Original file line number Diff line number Diff line change
@@ -63,6 +63,7 @@ public static void reboot(ThingActions actions) {
import org.openhab.binding.freeboxos.internal.handler.ActivePlayerHandler;
import org.openhab.binding.freeboxos.internal.handler.PlayerHandler;
import org.openhab.core.automation.annotation.RuleAction;
import org.openhab.core.thing.binding.ThingActions;
import org.openhab.core.thing.binding.ThingActionsScope;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@@ -89,4 +90,8 @@ public void reboot() {
}
>>>>>>> 46dadb1 SAT warnings handling
}

public static void reboot(ThingActions actions) {
((ActivePlayerActions) actions).reboot();
}
}
Original file line number Diff line number Diff line change
@@ -85,5 +85,4 @@ public void sendKey(String ip, String code, String key, boolean longPress, int c
public void reboot(int id) throws FreeboxException {
post(subPaths.get(id), SYSTEM_SUB_PATH, REBOOT_SUB_PATH);
}

}
Original file line number Diff line number Diff line change
@@ -496,7 +496,8 @@ private void startRefreshJob() {
int refreshInterval = getConfigAs(ApiConsumerConfiguration.class).refreshInterval;
logger.debug("Scheduling state update every {} seconds for thing {}...", refreshInterval,
getThing().getUID());
if (thing.getStatusInfo().getStatusDetail() == ThingStatusDetail.DUTY_CYCLE) {
ThingStatusDetail detail = thing.getStatusInfo().getStatusDetail();
if (ThingStatusDetail.DUTY_CYCLE.equals(detail)) {
boolean rebooting = true;
while (rebooting) {
try {
Original file line number Diff line number Diff line change
@@ -161,10 +161,9 @@ public void reboot() {
try {
internalCallReboot();
triggerChannel(new ChannelUID(getThing().getUID(), SYS_INFO, BOX_EVENT), "reboot_requested");
updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.DUTY_CYCLE,
"System rebooting, will take some seconds...");
updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.DUTY_CYCLE, "System rebooting...");
stopRefreshJob();
scheduler.schedule(this::initialize, 10, TimeUnit.SECONDS);
scheduler.schedule(this::initialize, 30, TimeUnit.SECONDS);
} catch (FreeboxException e) {
logger.warn("Error rebooting device : {}", e.getMessage());
}
Original file line number Diff line number Diff line change
@@ -216,7 +216,7 @@ public void sendKey(String key, boolean longPress, int count) {
try {
getManager(PlayerManager.class).sendKey(ip, remoteCode, aKey, longPress, count);
} catch (FreeboxException e) {
logger.info("Error sending key", e.getMessage());
logger.info("Error sending key : {}", e.getMessage());
}
} else {
logger.warn("A remote code must be configured in the on the player thing.");