Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks if there is a need for checks on installation #15

Closed
wants to merge 2 commits into from

Conversation

axelande
Copy link
Contributor

I'm not 100% sure but this could solve the issue with not working on first installation

@m-kuhn
Copy link
Member

m-kuhn commented Aug 28, 2024

Thanks.
Are you able to verify if this fixes the problem?

QOL Hint: to automate black etc, follow the steps on https://github.com/opengisch/qpip#contribute

@axelande
Copy link
Contributor Author

I'm not sure, it might fix the issue for the "plugin" that required qpip (if that is in the path when qpip gets installed). But it does not solve the issue that QGIS needs a restart for additional installation so it might be just a temporary fix. I write might fix it since it will behave differently when I installed it via a zip file compared from plugins.qgis.org.

Any ideas why it does not work before QGIS gets restarted btw?

@m-kuhn
Copy link
Member

m-kuhn commented Aug 28, 2024

Can you provide steps to reproduce?
I just tried the GeoDataFarm plugin, but if I'm not wrong, the released version doesn't currently require qpip (I see a message box with pip instructions)

@axelande
Copy link
Contributor Author

Hi, Yeah I wanted to use qpip as a required plugin (but then it needs to work and not be experimental) in the mean time you can test it fetching the latest version. Comment out this line: https://github.com/axelande/geodatafarm3/blob/master/GeoDataFarm.py#L48 (that tries to the same thing behind the scen as qpip), uninstall some python package (e.g. reportlab) and remove this comment: https://github.com/axelande/geodatafarm3/blob/master/metadata.txt#L92 and zip the plugin and try to install it

@axelande
Copy link
Contributor Author

axelande commented Sep 3, 2024

This does not really solve the issue :(

@axelande axelande closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants