Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ci test #12

Merged
merged 20 commits into from
Aug 21, 2024
Merged

Adding ci test #12

merged 20 commits into from
Aug 21, 2024

Conversation

axelande
Copy link
Contributor

Here is one example of how a automatic test could look like, now it is just checking on Ubuntu that the UI got the two different requirements and checking the version of the first one.

(Also added a polite message that the user needs to install pip if that is not present in the installed qgis)

Copy link
Member

@m-kuhn m-kuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for adding tests!

I have a couple of small questions/remarks which I hope will make this solid.

.github/workflows/test_plugin.yml Outdated Show resolved Hide resolved
.github/workflows/test_plugin.yml Outdated Show resolved Hide resolved
.github/workflows/test_plugin.yml Outdated Show resolved Hide resolved
a00_qpip/utils.py Outdated Show resolved Hide resolved
a00_qpip/plugin.py Outdated Show resolved Hide resolved
Axel Hörteborn and others added 2 commits August 20, 2024 19:01
a00_qpip/plugin.py Outdated Show resolved Hide resolved
a00_qpip/plugin.py Outdated Show resolved Hide resolved
a00_qpip/plugin.py Outdated Show resolved Hide resolved
@m-kuhn
Copy link
Member

m-kuhn commented Aug 21, 2024

Can you make sure the style test passes?
After that I think it's ok.

@m-kuhn m-kuhn merged commit 8b289b4 into opengisch:main Aug 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants