Layers as xarray.DataArray in split_map (ipyleaflet Map) #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you also overrite the |
|
The docs-build failed because the notebooks are executed with the folium backend. Would you be able to make similar changes to the split map function in foliumap.py? |
|
Not sure why the docs-build test failed on notebook |
|
The notebook issue seems caused by the recent updates of the lonboard package. I have reported it at developmentseed/lonboard#365. Ignoring this notebook for now. |
sthagen
pushed a commit
to sthagen/giswqs-leafmap
that referenced
this pull request
Jul 10, 2024
* Get crs and transform from rio accessor * Updated notebook (xarray section) * Layers as xarray in leafmap.Map.split_map * Updated notebook * Updated notebooks (docs) * Added array support for folium split_map * Updated notebook * Ignore notebook 83 execution * Enable split map dragging * Add error handling for compute_view --------- Co-authored-by: Qiusheng Wu <[email protected]>
kuzja111
pushed a commit
to kuzja111/leafmap
that referenced
this pull request
Jul 25, 2024
* Get crs and transform from rio accessor * Updated notebook (xarray section) * Layers as xarray in leafmap.Map.split_map * Updated notebook * Updated notebooks (docs) * Added array support for folium split_map * Updated notebook * Ignore notebook 83 execution * Enable split map dragging * Add error handling for compute_view --------- Co-authored-by: Qiusheng Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #680, here's a PR that implements the ability to pass
left_layerandright_layeras xarray.DataArray insplit_map, here only for the ipyleaflet.Map version for now.