♻️(backend) rename playlist tokens #2377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kernicPanel
force-pushed
the
backend-playlist-token
branch
from
26a690b to
f246a3f
Compare
kernicPanel
force-pushed
the
rename-playlist-tokens
branch
from
05ac9e3 to
da50295
Compare
kernicPanel
force-pushed
the
backend-playlist-token
branch
from
f246a3f to
f30c747
Compare
kernicPanel
force-pushed
the
rename-playlist-tokens
branch
7 times, most recently
from
ef74946 to
f55d2ee
Compare
lunika
reviewed
Aug 21, 2023
lunika
reviewed
Aug 22, 2023
kernicPanel
force-pushed
the
backend-playlist-token
branch
from
66895ba to
fba89e9
Compare
kernicPanel
force-pushed
the
rename-playlist-tokens
branch
from
a1d8271 to
4625321
Compare
kernicPanel
force-pushed
the
backend-playlist-token
branch
from
fba89e9 to
d8a338d
Compare
kernicPanel
force-pushed
the
rename-playlist-tokens
branch
2 times, most recently
from
28acfd4 to
57869c9
Compare
kernicPanel
force-pushed
the
backend-playlist-token
branch
from
d8a338d to
a681cc8
Compare
kernicPanel
force-pushed
the
rename-playlist-tokens
branch
from
57869c9 to
4368dc9
Compare
lunika
reviewed
Aug 22, 2023
Comment on lines
235
to
244
| # class PlaylistLtiTokenFactory(InstructorOrAdminLtiTokenFactory): | ||
| # """ | ||
| # LTI resource forged token for instructor or administrators with a playlist access. | ||
| # See `marsha.core.views.LTISelectView`. | ||
| # """ | ||
| # | ||
| # permissions = factory.SubFactory(ResourcePermissionsFactory, can_update=True) | ||
| # | ||
| # class Params: # pylint:disable=missing-class-docstring | ||
| # playlist = factory.SubFactory(PlaylistFactory) |
There was a problem hiding this comment.
Surely, you reviewed an outdated diff, as this code has been removed :/
src/backend/marsha/deposit/tests/api/depositedfiles/test_delete.py
Outdated
Show resolved
Hide resolved
kernicPanel
force-pushed
the
backend-playlist-token
branch
from
a681cc8 to
3dcba1d
Compare
kernicPanel
force-pushed
the
rename-playlist-tokens
branch
from
4368dc9 to
fa5fa7e
Compare
kernicPanel
force-pushed
the
backend-playlist-token
branch
from
3dcba1d to
4e5b7fb
Compare
kernicPanel
force-pushed
the
rename-playlist-tokens
branch
2 times, most recently
from
bdc07af to
db27a89
Compare
kernicPanel
force-pushed
the
backend-playlist-token
branch
from
4e5b7fb to
42fcb94
Compare
kernicPanel
force-pushed
the
rename-playlist-tokens
branch
from
db27a89 to
545a559
Compare
To avoid confusion, playlist_id has been renamed to port_to_playlist_id for portability requests.
As we are now using the playlists as token resource, it can be used for portability requests.
Permissions names related to playlists were not very intuitive.
As we now have only playlist tokens, the simple_jwt classes must be renamed for reflecting it.
As we now have only playlist tokens, the simple_jwt attributes must be renamed for reflecting it.
As we now have only playlist tokens, the simple_jwt attributes must be renamed for reflecting it.
kernicPanel
force-pushed
the
rename-playlist-tokens
branch
from
545a559 to
375affe
Compare
lunika
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
As we now have only playlist tokens, classes, attributes and variables must be renamed for reflecting it.