👔(backend) update organization assignation logic #1082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the organization assignation logic to ignore orders with pending signature, orders without a payment method, and refunded/refunding orders. Key changes include updating the test to randomly select non-binding order states, modifying the client API filtering logic, and updating the changelog.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/backend/joanie/tests/core/api/order/test_create.py | Updated order creation tests to randomly choose ignored order states for first organization and batch creation for the second organization. |
| src/backend/joanie/core/api/client/init.py | Modified the organization selection filter and updated the related docstring to reflect new binding order criteria. |
| CHANGELOG.md | Documented changes in organization assignation logic regarding order states to ignore. |
kernicPanel
reviewed
Apr 4, 2025
| product=relation.product, | ||
| course=relation.course, | ||
| state=enums.ORDER_STATE_DRAFT, | ||
| state=lazy(lambda: random.choice(ignored_states), str)(), |
Member
There was a problem hiding this comment.
I'd rather keep deterministic states, without random.choice.
I will add a fixup.
kernicPanel
force-pushed
the
improve/order-organization-assignation-logic
branch
from
01a1cae to
6bda6bc
Compare
Member
|
I just added tests, as current one doesn't cover the code. |
wilbrdt
approved these changes
Apr 7, 2025
wilbrdt
left a comment
wilbrdt
left a comment
There was a problem hiding this comment.
Being nitpicky but looks good to me!
jonathanreveille
approved these changes
Apr 7, 2025
kernicPanel
force-pushed
the
improve/order-organization-assignation-logic
branch
2 times, most recently
from
19ced06 to
c2f3fda
Compare
Currently only orders with inactive states (canceled, draft, assigned) were ignored in the organization assignation logic. But orders pending for signature or without payment method are take in account but most of time this kind of orders are abandoned. So it has been ask to ignore this kind of order during assignation. Furthermore, we did not ignore refunded and refunding orders. Resolve #1081
kernicPanel
force-pushed
the
improve/order-organization-assignation-logic
branch
from
c2f3fda to
4642af7
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Currently only orders with inactive states (canceled, draft, assigned) were ignored in the organization assignation logic. But orders pending for signature or without payment method are take in account but most of time this kind of orders are abandoned. So it has been ask to ignore this kind of order during assignation. Furthermore, we did not ignore refunded and refunding orders.
Resolve #1081