✨(backend) bind course offer into course webhook payload #1079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbpenrath
force-pushed
the
feat/synchronize-course-offers
branch
from
d8ef298 to
3bf964d
Compare
jbpenrath
force-pushed
the
feat/synchronize-course-offers
branch
3 times, most recently
from
c199330 to
babf6b7
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR integrates course offer information into the course webhook payload and updates the synchronization logic for certificate products. It also adds new tests to validate the offer logic for different product types and updates JSON serialization and signal handling accordingly.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/backend/joanie/tests/core/test_signals.py | Updated tests for certificate and credential product synchronization. |
| src/backend/joanie/tests/core/test_models_product.py | Added tests for offer processing in course run data and serialization. |
| src/backend/joanie/tests/core/test_models_course_run.py | Extended course run tests to validate certificate offer behavior. |
| src/backend/joanie/core/utils/webhooks.py | Modified JSON serialization and added explicit Content-Type header. |
| src/backend/joanie/core/signals.py | Enhanced signal handlers to support certificate-specific course run sync. |
| src/backend/joanie/core/models/products.py | Introduced get_equivalent_course_run_offer and get_serialized_certificated_course_runs. |
| src/backend/joanie/core/models/courses.py | Updated course serialization to include certificate offer and added get_certificate_offer. |
| src/backend/joanie/core/enums.py | Added new constants for course offers. |
| src/backend/joanie/core/apps.py | Registered new signal handler for product save. |
| CHANGELOG.md | Documented the inclusion of course offer information in webhook payload. |
kernicPanel
approved these changes
Apr 4, 2025
jonathanreveille
approved these changes
Apr 7, 2025
From Richie we recently add new fields to CourseRun models to set offer available on the CourseRun. As in Joanie we are able to set the course run offer according to product linked to the related course, we update the course synchronization to add this information.
kernicPanel
force-pushed
the
feat/synchronize-course-offers
branch
from
babf6b7 to
ddb2bf5
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
From Richie we recently add new fields to CourseRun models to set offer available on the CourseRun. As in Joanie we are able to set the course run offer according to product linked to the related course, we update the course synchronization to add this information.