Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] fix c++23 issue using make #8113

Merged
merged 1 commit into from
Sep 7, 2024
Merged

Conversation

dimitre
Copy link
Member

@dimitre dimitre commented Sep 6, 2024

closes #8111

@danoli3 danoli3 merged commit b0d1ff5 into openframeworks:master Sep 7, 2024
15 checks passed
@danoli3
Copy link
Member

danoli3 commented Sep 7, 2024

Still confusing since c++23 is available in Xcode 15.

Did you make sure you have run xcode-select --install

@danoli3
Copy link
Member

danoli3 commented Sep 7, 2024

sudo softwareupdate --all --install --force

@dimitre dimitre deleted the c20 branch September 7, 2024 20:01
@dimitre
Copy link
Member Author

dimitre commented Sep 10, 2024

I've run it again by editing config.make

export MAC_OS_CPP_VER = -std=c++23

and the full error is

error: error: invalid value 'c++23' in '-std=c++23'
invalid value 'c++23' in '-std=c++23'
note: use 'c++98' or 'c++03' for 'ISO C++ 1998 with amendments' standardnote: 
use 'c++98' or 'c++03' for 'ISO C++ 1998 with amendments' standard
note: use 'gnu++98' or 'gnu++03' for 'ISO C++ 1998 with amendments and GNU extensions' standard
note: use 'c++11' for 'ISO C++ 2011 with amendments' standard
note: use 'gnu++11' for 'ISO C++ 2011 with amendments and GNU extensions' standardnote: 
use 'gnu++98' or 'gnu++03' for 'ISO C++ 1998 with amendments and GNU extensions' standardnote: 
use 'c++14' for 'ISO C++ 2014 with amendments' standard
note: note: use 'c++11' for 'ISO C++ 2011 with amendments' standarduse 'gnu++14' for 'ISO C++ 2014 with amendments and GNU extensions' standard

note: note: use 'gnu++11' for 'ISO C++ 2011 with amendments and GNU extensions' standarduse 'c++17' for 'ISO C++ 2017 with amendments' standard

note: use 'gnu++17' for 'ISO C++ 2017 with amendments and GNU extensions' standardnote: 
use 'c++14' for 'ISO C++ 2014 with amendments' standard
note: note: use 'gnu++14' for 'ISO C++ 2014 with amendments and GNU extensions' standarduse 'c++20' for 'ISO C++ 2020 DIS' standard

note: note: use 'c++17' for 'ISO C++ 2017 with amendments' standarduse 'gnu++20' for 'ISO C++ 2020 DIS with GNU extensions' standard

note: note: use 'gnu++17' for 'ISO C++ 2017 with amendments and GNU extensions' standarduse 'c++2b' for 'Working draft for ISO C++ 2023 DIS' standard

note: note: use 'c++20' for 'ISO C++ 2020 DIS' standarduse 'gnu++2b' for 'Working draft for ISO C++ 2023 DIS with GNU extensions' standard

note: use 'gnu++20' for 'ISO C++ 2020 DIS with GNU extensions' standard
note: use 'c++2b' for 'Working draft for ISO C++ 2023 DIS' standard
note: use 'gnu++2b' for 'Working draft for ISO C++ 2023 DIS with GNU extensions' standard

@dimitre
Copy link
Member Author

dimitre commented Sep 10, 2024

so maybe c++2b is the parameter you want to enable 'Working draft for ISO C++ 2023 DIS' standard

@danoli3
Copy link
Member

danoli3 commented Sep 10, 2024 via email

@dimitre
Copy link
Member Author

dimitre commented Sep 10, 2024

it was hard to debug because platform templates were overriding with c++17
and in some cases when we use "vscode" and "osx" templates it copies config.make twice, so the last added template will count.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[macOS] make not working due to c++23
2 participants