-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 5933 - less greedy language refresh #6038
base: develop
Are you sure you want to change the base?
Conversation
Impacted files: * `background_task_language_refresh.dart`: now we restart only the dedicated product type queue instead of all * `operation_type.dart`: new `getProductType` method; minor refactoring * `offline_tasks_page.dart`: display the product type for tasks, when available
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6038 +/- ##
==========================================
- Coverage 9.54% 6.46% -3.09%
==========================================
Files 325 443 +118
Lines 16411 25137 +8726
==========================================
+ Hits 1567 1625 +58
- Misses 14844 23512 +8668 ☔ View full report in Codecov by Sentry. |
@teolemon I've just pushed a very interesting commit, focused on optimizing the "get the most interesting products that haven't got the correct language yet" database query:
I do believe you shouldn't have the UI freeze effect now. |
What
Part of
Impacted files
background_task_language_refresh.dart
: now we restart only the dedicated product type queue instead of alloperation_type.dart
: newgetProductType
method; minor refactoringoffline_tasks_page.dart
: display the product type for tasks, when available