feat: Contribute to your country link #5874
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jnnabugwu/smooth-app into contribute-to-your-country-link
…tribute.dart Co-authored-by: monsieurtanuki <[email protected]>
…jnnabugwu/smooth-app into contribute-to-your-country-link
…jnnabugwu/smooth-app into contribute-to-your-country-link
…our-country-link' of https://github.com/jnnabugwu/smooth-app into contribute-to-your-country-link
…jnnabugwu/smooth-app into contribute-to-your-country-link
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5874 +/- ##
==========================================
- Coverage 9.54% 6.85% -2.70%
==========================================
Files 325 428 +103
Lines 16411 23598 +7187
==========================================
+ Hits 1567 1617 +50
- Misses 14844 21981 +7137 ☔ View full report in Codecov by Sentry. |
| @@ -319,6 +335,19 @@ class UserPreferencesContribute extends AbstractUserPreferences { | |||
| builder: (_) => tile, | |||
| ); | |||
| } | |||
|
|
|||
| Future<String> returnCountry(BuildContext context) async { | |||
There was a problem hiding this comment.
Please remove that method, we don't need it.
There was a problem hiding this comment.
Whoops yeah thats my bad
| @@ -0,0 +1,25 @@ | |||
| // TODO(monsieurtanuki): the code is to be moved to openfoodfacts-dart | |||
| class TmpCountryWikiLinks { | |||
| final Map<String, String> wikiLinks = <String, String>{ | |||
There was a problem hiding this comment.
Suggested change
| final Map<String, String> wikiLinks = <String, String>{ | |
| static final Map<OpenFoodFactsCountry, String> wikiLinks = <OpenFoodFactsCountry, String>{ |
| @@ -94,6 +96,20 @@ class UserPreferencesContribute extends AbstractUserPreferences { | |||
| () async => _share(appLocalizations.contribute_share_content), | |||
| Icons.adaptive.share, | |||
| ), | |||
| _getListTile( | |||
There was a problem hiding this comment.
We display nothing if the country has no wiki links.
| _getListTile( | ||
| appLocalizations.help_improve_country, | ||
| () async { | ||
| final String country = await returnCountry(context); |
There was a problem hiding this comment.
Please use ProductQuery.getCountry() instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
feat: Added a method and map to get the correct country locale for the corresponding wiki page.
Screenshot
Fixes bug(s)
Part of