feat: 5207 - new "My proofs" and "Proof" pages #5389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New files: * `price_proof_page.dart`: Full page display of a proof. * `prices_proofs_page.dart`: Page that displays the latest proofs of the current user. Impacted files: * `app_en.arb`: added 3 labels for "my proofs" * `app_fr.arb`: added 3 labels for "my proofs" * `price_data_widget.dart`: instead of a web app link, we open the new "my proof" page * `user_preferences_account.dart`: added a link to open the new "my proofs" page
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5389 +/- ##
==========================================
- Coverage 9.54% 7.29% -2.26%
==========================================
Files 325 390 +65
Lines 16411 19964 +3553
==========================================
- Hits 1567 1456 -111
- Misses 14844 18508 +3664 ☔ View full report in Codecov by Sentry. |
|
For the record it was my "1024th pull request merged" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Screenshots
Fixes bug(s)
Files
New files:
price_proof_page.dart: Full page display of a proof.prices_proofs_page.dart: Page that displays the latest proofs of the current user.Impacted files:
app_en.arb: added 3 labels for "my proofs"app_fr.arb: added 3 labels for "my proofs"price_data_widget.dart: instead of a web app link, we open the new "my proof" pageuser_preferences_account.dart: added a link to open the new "my proofs" page