Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 3594 - expand/collapse for packagings components #3597

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

monsieurtanuki
Copy link
Contributor

New files:

  • edit_new_packagings_component.dart: Edit display of a single ProductPackaging component.
  • edit_new_packagings_helper.dart: Helper about packaging component edition. Useful with controllers.

Impacted file:

  • edit_new_packagings.dart: refactored using new classes EditNewPackagingsComponent and EditNewPackagingsHelper

What

  • Now there's an expand/collapse feature on the new edit packagings page.
  • Existing components are collapsed by default.
  • New ("just added") components are expanded by default.
  • Some refactoring in this PR, as the main file was getting too big and too confusing.

Screenshot

New landing page, with all components collapsed:
Capture d’écran 2023-01-19 à 09 27 59

Part of

New files:
* `edit_new_packagings_component.dart`: Edit display of a single ProductPackaging component.
* `edit_new_packagings_helper.dart`: Helper about packaging component edition. Useful with controllers.

Impacted file:
* `edit_new_packagings.dart`: refactored using new classes `EditNewPackagingsComponent` and `EditNewPackagingsHelper`
@monsieurtanuki monsieurtanuki requested a review from a team as a code owner January 19, 2023 08:29
@github-actions github-actions bot added ✏️ Editing - Packaging input Related to the structured input of food packaging. 🥫 Product page labels Jan 19, 2023
Copy link
Member

@AshAman999 AshAman999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

@monsieurtanuki monsieurtanuki merged commit 05fd0cc into openfoodfacts:develop Jan 19, 2023
@monsieurtanuki
Copy link
Contributor Author

Thank you @AshAman999 @teolemon for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Editing - Packaging input Related to the structured input of food packaging. 🥫 Product page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants