Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #2513 - product page - moved higher the action bar #2615

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

monsieurtanuki
Copy link
Contributor

Impacted file:

  • new_product_page.dart: moved higher the action bar

What

  • In the product page, the action bar (list / edit / share) is now between the summary card and the health card. Instead of being down under, mate.
  • Might be problematic as each list takes room (cf. screenshots)

Screenshot

top ...scrolling down...
Capture d’écran 2022-07-18 à 08 02 10 Capture d’écran 2022-07-18 à 08 02 33

Fixes bug(s)

Impacted file:
* `new_product_page.dart`: moved higher the action bar
@monsieurtanuki monsieurtanuki requested a review from a team as a code owner July 18, 2022 06:05
@codecov-commenter
Copy link

Codecov Report

Merging #2615 (e6ec70f) into develop (2ea0da3) will decrease coverage by 1.33%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #2615      +/-   ##
==========================================
- Coverage     8.86%   7.52%   -1.34%     
==========================================
  Files          161     212      +51     
  Lines         6623   10148    +3525     
==========================================
+ Hits           587     764     +177     
- Misses        6036    9384    +3348     
Impacted Files Coverage Δ
...kages/smooth_app/lib/widgets/attribute_button.dart 0.00% <0.00%> (-92.00%) ⬇️
...s/smooth_app/lib/data_models/user_preferences.dart 8.73% <0.00%> (-23.57%) ⬇️
packages/smooth_app/lib/themes/smooth_theme.dart 60.00% <0.00%> (-22.98%) ⬇️
...p/lib/generic_lib/dialogs/smooth_alert_dialog.dart 15.11% <0.00%> (-19.10%) ⬇️
...mooth_app/lib/data_models/product_preferences.dart 24.65% <0.00%> (-6.78%) ⬇️
packages/smooth_app/lib/main.dart 14.16% <0.00%> (-3.73%) ⬇️
.../smooth_app/lib/pages/onboarding/welcome_page.dart 0.00% <0.00%> (-3.13%) ⬇️
.../smooth_app/lib/pages/onboarding/scan_example.dart 0.00% <0.00%> (-2.28%) ⬇️
...p/lib/pages/onboarding/consent_analytics_page.dart 0.00% <0.00%> (-1.57%) ⬇️
...smooth_app/lib/pages/product/new_product_page.dart 0.00% <0.00%> (-0.88%) ⬇️
... and 223 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b52473...e6ec70f. Read the comment docs.

Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @monsieurtanuki

Lots of people will like this change

@monsieurtanuki monsieurtanuki merged commit 5816934 into openfoodfacts:develop Jul 18, 2022
@monsieurtanuki
Copy link
Contributor Author

Thank you @M123-dev for your review!
If only all PRs could be that easy...

@M123-dev
Copy link
Member

Taking a look at #2396 later or at the latest tomorrow

@g123k
Copy link
Collaborator

g123k commented Jul 18, 2022

I wonder if we shouldn't use a FAB in this screen to have access to the three features without even scrolling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move "edit product" "add to list" & "share" buttons between the Summary card and the Health Card
4 participants