fix: #1126 More appealing empty history screen #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thank you @bhattabhi013 for this PR!
Please read my comments.
In addition to them:
- I think the whole block should be vertically centered, which was not obvious in your code or in your screenshot
- regarding the PR title, please use "fix: " instead, as this will be used for automatic PR sorting
- I'm quite sure that your PR doesn't look good in dark mode; please add screenshots in both day and night mode
packages/smooth_app/lib/pages/product/common/product_list_page.dart
Outdated
Show resolved
Hide resolved
packages/smooth_app/lib/pages/product/common/product_list_page.dart
Outdated
Show resolved
Hide resolved
packages/smooth_app/lib/pages/product/common/product_list_page.dart
Outdated
Show resolved
Hide resolved
packages/smooth_app/lib/pages/product/common/product_list_page.dart
Outdated
Show resolved
Hide resolved
packages/smooth_app/lib/pages/product/common/product_list_page.dart
Outdated
Show resolved
Hide resolved
|
Thanks for the feedback @monsieurtanuki . I'll resolve the pending issues so that the PR can be merged. |
|
I've fixed the pending issues and updated the changes.
|
M123-dev
reviewed
Mar 15, 2022
packages/smooth_app/lib/pages/product/common/product_list_page.dart
Outdated
Show resolved
Hide resolved
packages/smooth_app/lib/pages/product/common/product_list_page.dart
Outdated
Show resolved
Hide resolved
M123-dev
changed the title
M123-dev
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
More appealing empty history screen
Screenshot
Fixes bug(s)
Part of
(please be as granular as possible)