Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: data-quality - minimum number of ingredients #11152

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

benbenben2
Copy link
Collaborator

What

push data quality error if ingredients count is lower than the expected number of ingredients

Screenshot

Screenshot_20241221_084555
Screenshot_20241221_084613
Screenshot_20241221_084631

Related issue(s) and discussion

@benbenben2 benbenben2 self-assigned this Dec 21, 2024
@benbenben2 benbenben2 requested a review from a team as a code owner December 21, 2024 08:04
@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies categories 🧽 Data quality https://wiki.openfoodfacts.org/Quality 🧪 tests labels Dec 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 49.04%. Comparing base (ac175ce) to head (dc3213f).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
lib/ProductOpener/DataQualityFood.pm 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11152      +/-   ##
==========================================
+ Coverage   40.64%   49.04%   +8.39%     
==========================================
  Files          77       78       +1     
  Lines       22316    22379      +63     
  Branches     5354     5366      +12     
==========================================
+ Hits         9071    10975    +1904     
+ Misses      12067    10058    -2009     
- Partials     1178     1346     +168     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
categories 🧽 Data quality https://wiki.openfoodfacts.org/Quality 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests
Projects
Status: Needs review
Development

Successfully merging this pull request may close these issues.

Create a quality check for number of ingredients
3 participants