Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

feat: removed Mint package manager dependcies as it was not used, uses Carthage as package manager. #883

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

hakuamesan
Copy link

PR Description

Describe the changes made and why they were made instead of how they were made.

Type of Changes

As we currently use only the Carthage package manager, removed dependency of Mint package manager installation from the scripts/setup.sh file.

Proposed changes

  • Delete Mint package manager installation shell scripts from the scripts/setup.sh file
  • Retain Carthage as package manager

Screenshots

Before

After

Checklist

Make sure you've done all the following (Put an x in the boxes that apply.)

  • If you have multiple commits please combine them into one commit by squashing them.
  • Code is well documented
  • Included unit tests for new functionality
  • All user-visible strings are made translatable
  • Code passes Travis builds in your branch

@teolemon teolemon requested a review from a team February 6, 2021 13:11
Copy link
Collaborator

@philippeauriach philippeauriach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mint was used as a package manager to install a specific Carthage version in the install script (so not for the actual project but to make sure that the environment has the correct Carthage version).

Nonetheless, I agree to remove it as I think developers should handle their own Carthage installation (I personally had trouble with another projects after running setup.sh as it removed my Carthage installation to install another [older] version). Just make sure that it is documented somewhere, and maybe a check and warning in the setup.sh if Carthage is not installed. Github Actions scripts should also be updated to install homebrew before building.

@teolemon teolemon changed the title removed Mint package manager dependcies as it was not used, uses Carthage as package manager. feat: removed Mint package manager dependcies as it was not used, uses Carthage as package manager. Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants