Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Dashboard): fix Proof count. Cleanup Price & Proof headers #907

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

raphodn
Copy link
Member

@raphodn raphodn commented Oct 1, 2024

What

User Prices

  • move Dashboard link down
  • remove Share button

User proofs

  • fix count
  • move Dashboard link down

@raphodn raphodn merged commit fe0c712 into master Oct 1, 2024
8 of 9 checks passed
@raphodn raphodn deleted the raphodn/dashboard-price-proof-header-cleanup branch October 1, 2024 15:14
@raphodn
Copy link
Member Author

raphodn commented Oct 1, 2024

@serpico possibly fixes another bug on the proof count that was displayed

@serpico
Copy link

serpico commented Oct 1, 2024

@raphodn how much work would it take to add order like :

  • proof with the greater number of prices first/at the top vs oldest first/at the top
  • oldest date first/at the top vs newest date first/at the top

although I could totally wait for the more versatile/powerful search feature #839

@raphodn
Copy link
Member Author

raphodn commented Oct 1, 2024

ordering is easy :)
can you copy-paste your message in #839 ?
I renamed the issue to include ordering as well !

but filtering is a bit harder
will need to revamp the current mecanism (how it works right now is not scalable, realized this in #904)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants