-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Home): reorganize home page sections. move buttons to header #865
Conversation
this.getTodayPriceCount() | ||
}, | ||
methods: { | ||
getPrices() { | ||
this.loading = true | ||
return api.getPrices({ size: 5 }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How many prices should we display ?
Maybe load 5, but display only 2 or 3 on small screens ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd load up to 25, adding "3 minutes ago", up to"24 hours ago" instead of Today's date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok will re-add the "relative time info" in the PriceCard in a different PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and I need to think about loading more data for bigger screens (different PR as well)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bumped to 25 (and kept it to 5 on small screens) in this commit : 588c97a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of Today's date
its the price's date that is displayed. sometimes prices are added for a different date.
indeed it can be confusing..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was more to make it more alive and exciting, I wasn't particularly confused by anything
e2de3c8
to
1828be9
Compare
1828be9
to
6a687c2
Compare
What
See issue #843
Improved Home Page
Todo (here or next PR)
Screenshot