Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Home): reorganize home page sections. move buttons to header #865

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

raphodn
Copy link
Member

@raphodn raphodn commented Sep 28, 2024

What

See issue #843

Improved Home Page

  • show basic stats
  • show 25 latest prices (5 on small screens) + button to see more
  • Search & Add actions moved to the header (and they remain available in the top-left menu)

Todo (here or next PR)

  • more stats (locations, users)
  • center "Latest prices" button

Screenshot

Before After
Desktop image image
Mobile image image

this.getTodayPriceCount()
},
methods: {
getPrices() {
this.loading = true
return api.getPrices({ size: 5 })
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How many prices should we display ?
Maybe load 5, but display only 2 or 3 on small screens ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd load up to 25, adding "3 minutes ago", up to"24 hours ago" instead of Today's date

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok will re-add the "relative time info" in the PriceCard in a different PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and I need to think about loading more data for bigger screens (different PR as well)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bumped to 25 (and kept it to 5 on small screens) in this commit : 588c97a

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of Today's date

its the price's date that is displayed. sometimes prices are added for a different date.
indeed it can be confusing..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was more to make it more alive and exciting, I wasn't particularly confused by anything

@raphodn raphodn force-pushed the raphodn/home-page-v2 branch from e2de3c8 to 1828be9 Compare September 28, 2024 14:14
@raphodn raphodn force-pushed the raphodn/home-page-v2 branch from 1828be9 to 6a687c2 Compare September 28, 2024 14:24
@raphodn raphodn merged commit aa973b0 into master Sep 28, 2024
5 of 6 checks passed
@raphodn raphodn deleted the raphodn/home-page-v2 branch September 28, 2024 14:25
@raphodn raphodn linked an issue Sep 28, 2024 that may be closed by this pull request
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Revamp the landing page
2 participants