Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update labeler.yml to V5 syntax #762

Merged
merged 1 commit into from
Aug 21, 2024
Merged

ci: Update labeler.yml to V5 syntax #762

merged 1 commit into from
Aug 21, 2024

Conversation

teolemon
Copy link
Member

@teolemon teolemon commented Aug 21, 2024

What

Following #735

  • ci: Update labeler.yml to V5 syntax
  • additional fixes : bcee5f4

@raphodn
Copy link
Member

raphodn commented Aug 21, 2024

closing (reverted #735 in #763)

@raphodn raphodn closed this Aug 21, 2024
@raphodn
Copy link
Member

raphodn commented Aug 21, 2024

reopening after re-reverting #765

- 'src/views/AddPriceSingle.vue'
- 'src/views/AddPriceMultiple.vue'
- changed-files:
- any-glob-to-any-file: 'src/views/AddPriceHome.vue'
Copy link
Member

@raphodn raphodn Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be 1 line with an array of values ? instead of 3 identical/overwritten? lines

https://github.com/actions/labeler#basic-examples

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works with my syntax on other repos 🤷

@teolemon teolemon merged commit 86984de into master Aug 21, 2024
7 of 9 checks passed
@teolemon teolemon deleted the teolemon-patch-1 branch August 21, 2024 14:02
@raphodn
Copy link
Member

raphodn commented Aug 22, 2024

@teolemon doesn't seem to work ? see one of the latest PRs (for instance #769)

@teolemon
Copy link
Member Author

  • instead of reverting, let's fix master so that the labeler works again. The "actions" tab is there for us
  • also for release please, you're using slightly different conventions from the rest of the repos, so I need to have an extra look (but I think we should just fix the config in crowdin or release please, and missing a PR or 2 is not dramatic)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants