-
-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump HL version to 1.14. #1827
Open
Apprentice-Alchemist
wants to merge
7
commits into
openfl:develop
Choose a base branch
from
Apprentice-Alchemist:update-hl-to-1.14
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Bump HL version to 1.14. #1827
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d34e375
Bump HL version to 1.14.
Apprentice-Alchemist 90403f0
Uses Lime's vendored mbedtls for Hashlink.
Apprentice-Alchemist b48b9d0
Try to fix HL Windows build.
Apprentice-Alchemist 937f8aa
Try to fix HL ssl.hdll Windows build.
Apprentice-Alchemist 2b47b25
Try to fix HL ssl Windows build.
Apprentice-Alchemist ab8ab42
Add missing compilerflag in mbedtls-files.xml.
Apprentice-Alchemist c2e57ea
Exclude net_sockets.c from HL mbedtls build.
Apprentice-Alchemist File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
#include <windows.h> | ||
|
||
typedef struct { | ||
CRITICAL_SECTION cs; | ||
char is_valid; | ||
} mbedtls_threading_mutex_t; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
WIN32_LEAN_AND_MEAN
is defined before this include then the compiler error withnet_sockets.c
can be avoided.Otherwise, the way hashlink currently avoids this issue is by undefining the
MBEDTLS_NET_C
define: https://github.com/HaxeFoundation/hashlink/blob/9cf7efa118409bef3a7c263bffc36da107751e60/include/mbedtls/include/mbedtls/config.h#L2153C1-L2153C24