Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: simplify constructors, make client options consistent, bump to 0.1.0 #215

Merged
merged 3 commits into from
Sep 29, 2023
Merged

refactor: simplify constructors, make client options consistent, bump to 0.1.0 #215

merged 3 commits into from
Sep 29, 2023

Conversation

booniepepper
Copy link
Contributor

@booniepepper booniepepper commented Sep 29, 2023 •
edited
Loading

Description

  • refactor(java-sdk): simplify OpenFgaClient and OpenFgaApi constructors
  • refactor(java-sdk): Add more Options classes, make options class naming consistent
  • chore(java-sdk): bump version to 0.1.0

References

Generates openfga/java-sdk#24

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@booniepepper booniepepper mentioned this pull request Sep 29, 2023
Merged
4 tasks
@booniepepper booniepepper marked this pull request as ready for review September 29, 2023 18:38
@booniepepper booniepepper requested a review from a team as a code owner September 29, 2023 18:38
@rhamzeh rhamzeh added this pull request to the merge queue Sep 29, 2023
Merged via the queue into main with commit 230c669 Sep 29, 2023
5 of 6 checks passed
@rhamzeh rhamzeh deleted the refactor/java-sdk-constructors branch September 29, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamzeh rhamzeh rhamzeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@booniepepper @rhamzeh