Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tmsagarofficial patch 1 #42

Merged
merged 6 commits into from
Oct 7, 2024

Conversation

tmsagarofficial
Copy link
Contributor

Description

Grammar and typo fixes

References

This is just a simple PR to address the issues as mentioned in the descrption

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • [NA] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • [NA] I have added tests to validate that the change in functionality is working as expected

Copy link
Member

@aaguiarz aaguiarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tmsagarofficial!!

It looks great!

@tmsagarofficial
Copy link
Contributor Author

Thanks @aaguiarz

@tmsagarofficial
Copy link
Contributor Author

Can hacktoberfest label be added to this? @aaguiarz

@aaguiarz
Copy link
Member

aaguiarz commented Oct 7, 2024

@tmsagarofficial just added it

@tmsagarofficial
Copy link
Contributor Author

@aaguiarz Ohh okay Thanks , I see that this repo doesn't have hacktoberfest label 😅, In this case adding hacktoberfest-accepted would help me make this contribution count towards some streak.

@aaguiarz
Copy link
Member

aaguiarz commented Oct 7, 2024

@tmsagarofficial I just added the hacktoberfest / hacktoberfest-accepted labels to the repo and to the PR.

Does this work?

@tmsagarofficial
Copy link
Contributor Author

tmsagarofficial commented Oct 7, 2024 via email

@aaguiarz aaguiarz merged commit 0fc4d08 into openfga:main Oct 7, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants