Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): incorrect path for sync client README #44

Merged
merged 1 commit into from
Dec 1, 2023
Merged

fix(docs): incorrect path for sync client README #44

merged 1 commit into from
Dec 1, 2023

Conversation

kimgault
Copy link

@kimgault kimgault commented Nov 6, 2023

Fixing incorrect path for synchronous client in README.md

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@kimgault kimgault requested a review from a team as a code owner November 6, 2023 20:55
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Nov 6, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: kimgault / name: Kim Gault (f9c807a)

@kimgault kimgault changed the title fixREADME.md: incorrect path for synchronous client fix: README.md incorrect path for synchronous client Nov 6, 2023
@kimgault kimgault changed the title fix: README.md incorrect path for synchronous client fix(docs): incorrect path for sync client README Nov 6, 2023
rhamzeh
rhamzeh approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@rhamzeh rhamzeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @kimgault !

adriantam added a commit to openfga/sdk-generator that referenced this pull request Nov 14, 2023
@adriantam
fix(python): correct path for sync client
dd77f67 
Implement changes for openfga/python-sdk#44
@adriantam adriantam mentioned this pull request Nov 14, 2023
Merged
4 tasks
@adriantam adriantam added this pull request to the merge queue Nov 14, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 14, 2023
@rhamzeh rhamzeh added this pull request to the merge queue Dec 1, 2023
@kimgault kimgault closed this Dec 1, 2023
Merged via the queue into openfga:main with commit 263d8a9 Dec 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamzeh rhamzeh rhamzeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kimgault @rhamzeh