Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: moved store validation to language #286

Merged
merged 1 commit into from
Jul 15, 2024
Merged

chore: moved store validation to language #286

merged 1 commit into from
Jul 15, 2024

Conversation

d-jeffery
Copy link
Contributor

@d-jeffery d-jeffery commented Jul 1, 2024 •
edited by rhamzeh
Loading

Description

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@d-jeffery d-jeffery requested a review from ewanharris July 1, 2024 22:23
@d-jeffery d-jeffery requested a review from rhamzeh July 8, 2024 14:50
@d-jeffery d-jeffery force-pushed the feat/validation branch 2 times, most recently from ad16a1b to f6ac70c Compare July 8, 2024 15:05
@d-jeffery d-jeffery marked this pull request as ready for review July 8, 2024 19:43
@d-jeffery d-jeffery requested review from a team as code owners July 8, 2024 19:43
@d-jeffery d-jeffery force-pushed the feat/validation branch 2 times, most recently from 46a537b to 8c639df Compare July 8, 2024 21:03
rhamzeh
rhamzeh reviewed Jul 9, 2024
View reviewed changes
pkg/js/tests/validate-rules.test.ts Show resolved Hide resolved
pkg/js/tests/validate-rules.test.ts Show resolved Hide resolved
pkg/js/tests/validate-rules.test.ts Show resolved Hide resolved
pkg/js/tests/validate-rules.test.ts Show resolved Hide resolved
pkg/js/validator/validate-rules.ts Show resolved Hide resolved
pkg/js/validator/validate-store.ts Outdated Show resolved Hide resolved
pkg/js/validator/validate-store.ts Outdated Show resolved Hide resolved
pkg/js/validator/validate-store.ts Outdated Show resolved Hide resolved
pkg/js/validator/validate-store.ts Show resolved Hide resolved
pkg/js/validator/validate-store.ts Show resolved Hide resolved
@d-jeffery d-jeffery mentioned this pull request Jul 10, 2024
Open
@d-jeffery d-jeffery requested a review from rhamzeh July 11, 2024 21:58
rhamzeh
rhamzeh approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@rhamzeh rhamzeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I removed the reference to #226 from the description

@d-jeffery d-jeffery added this pull request to the merge queue Jul 15, 2024
Merged via the queue into main with commit 8dd93a9 Jul 15, 2024
18 checks passed
@d-jeffery d-jeffery deleted the feat/validation branch July 15, 2024 17:32
@ewanharris ewanharris mentioned this pull request Sep 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamzeh rhamzeh rhamzeh approved these changes

@ewanharris ewanharris Awaiting requested review from ewanharris

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for validating the store file
2 participants
@d-jeffery @rhamzeh