Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support apiUrl configuration option #60

Merged
merged 2 commits into from
Feb 6, 2024
Merged

feat: support apiUrl configuration option #60

merged 2 commits into from
Feb 6, 2024

Conversation

ewanharris
Copy link
Member

@ewanharris ewanharris commented Feb 2, 2024 •
edited
Loading

Description

Adds support for an apiUrl configuration option and deprecated the existing apiHost and apiScheme options

References

Part of openfga/sdk-generator/issues/298
Generated from: openfga/sdk-generator#302

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@ewanharris ewanharris requested a review from a team as a code owner February 2, 2024 18:34
@ewanharris ewanharris mentioned this pull request Feb 2, 2024
Merged
4 tasks
evansims
evansims previously approved these changes Feb 5, 2024
View reviewed changes
@ewanharris ewanharris added this pull request to the merge queue Feb 6, 2024
Merged via the queue into main with commit a4960c8 Feb 6, 2024
19 checks passed
@ewanharris ewanharris deleted the feat/apiUrl-configuration branch February 6, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamzeh rhamzeh rhamzeh approved these changes

@evansims evansims evansims left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ewanharris @evansims @rhamzeh