Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support start_time parameter on read_changes #186

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ryanpq
Copy link
Contributor

@ryanpq ryanpq commented Dec 20, 2024

Description

Adds support for the start_time variable for read changes.

References

openfga/sdk-generator#455

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@ryanpq ryanpq requested review from a team as code owners December 20, 2024 18:48
@ryanpq
Copy link
Contributor Author

ryanpq commented Dec 20, 2024

Note: This currently includes the read changes start_time variable but does not include Batch Check updates.

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.65%. Comparing base (81ab8be) to head (cda05b4).

Files with missing lines Patch % Lines
api.ts 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
- Coverage   87.70%   87.65%   -0.06%     
==========================================
  Files          23       23              
  Lines        1139     1142       +3     
  Branches      177      179       +2     
==========================================
+ Hits          999     1001       +2     
  Misses         83       83              
- Partials       57       58       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryanpq ryanpq force-pushed the feat-support-start_time-parameter-on-read_changes branch from 4e02e59 to cda05b4 Compare December 30, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants