fix client headers

openfga · Dec 17, 2024 · 4637704 · 4637704
1 parent c587a9a
commit 4637704
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/client.ts b/client.ts
@@ -680,8 +680,6 @@ export class OpenFgaClient extends BaseAPI {
       maxParallelRequests = DEFAULT_MAX_METHOD_PARALLEL_REQS,
     } = options;
 
-    // TODO this right? Do it here?
-    setHeaderIfNotSet(headers, CLIENT_METHOD_HEADER, "BatchCheck");
     setHeaderIfNotSet(headers, CLIENT_BULK_REQUEST_ID_HEADER, generateRandomIdWithNonUniqueFallback());
 
     const correlationIdToCheck = new Map<string, ClientBatchCheckItem>();
@@ -725,7 +723,7 @@ export class OpenFgaClient extends BaseAPI {
         consistency: options.consistency,
       };
 
-      const response = await this.singleBatchCheck(batchRequest, options);
+      const response = await this.singleBatchCheck(batchRequest, { ...options, headers });
       return response.result;
     });
 

diff --git a/tests/client.test.ts b/tests/client.test.ts
@@ -598,7 +598,8 @@ describe("OpenFGA Client", () => {
             },
           },
         };
-        const scope = nocks.singleBatchCheck(baseConfig.storeId!, mockedResponse, undefined, ConsistencyPreference.HigherConsistency, "01GAHCE4YVKPQEKZQHT2R89MQV");
+
+        const scope = nocks.singleBatchCheck(baseConfig.storeId!, mockedResponse, undefined, ConsistencyPreference.HigherConsistency, "01GAHCE4YVKPQEKZQHT2R89MQV").matchHeader("X-OpenFGA-Client-Bulk-Request-Id", /.*/);
 
         expect(scope.isDone()).toBe(false);
         const response = await fgaClient.batchCheck({
@@ -661,8 +662,8 @@ describe("OpenFGA Client", () => {
           },
         };
 
-        const scope0 = nocks.singleBatchCheck(baseConfig.storeId!, mockedResponse0, undefined, ConsistencyPreference.HigherConsistency, "01GAHCE4YVKPQEKZQHT2R89MQV");
-        const scope1 = nocks.singleBatchCheck(baseConfig.storeId!, mockedResponse1, undefined, ConsistencyPreference.HigherConsistency, "01GAHCE4YVKPQEKZQHT2R89MQV");
+        const scope0 = nocks.singleBatchCheck(baseConfig.storeId!, mockedResponse0, undefined, ConsistencyPreference.HigherConsistency, "01GAHCE4YVKPQEKZQHT2R89MQV").matchHeader("X-OpenFGA-Client-Bulk-Request-Id", /.*/);
+        const scope1 = nocks.singleBatchCheck(baseConfig.storeId!, mockedResponse1, undefined, ConsistencyPreference.HigherConsistency, "01GAHCE4YVKPQEKZQHT2R89MQV").matchHeader("X-OpenFGA-Client-Bulk-Request-Id", /.*/);
 
         expect(scope0.isDone()).toBe(false);
         expect(scope1.isDone()).toBe(false);