Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add batch check telemetry attribute #143

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jimmyjames
Copy link
Contributor

Description

Adds telemetry attribute fga-client.request.batch_check_size to capture number of checks in batch check request

References

Similar to openfga/js-sdk@59c000b

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@jimmyjames jimmyjames requested a review from a team as a code owner February 6, 2025 07:39
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 32.82%. Comparing base (b7484e6) to head (baedf12).

Files with missing lines Patch % Lines
src/main/java/dev/openfga/sdk/api/OpenFgaApi.java 80.00% 0 Missing and 1 partial ⚠️

❌ Your project status has failed because the head coverage (32.82%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #143      +/-   ##
============================================
+ Coverage     32.78%   32.82%   +0.04%     
- Complexity      973      974       +1     
============================================
  Files           182      182              
  Lines          6872     6878       +6     
  Branches        764      766       +2     
============================================
+ Hits           2253     2258       +5     
  Misses         4512     4512              
- Partials        107      108       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@piotrooo piotrooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants